Update artifact actions to v4 #168 #170
Conversation
javierfreire
force-pushed
the
artifact-actions-v4
branch
3 times, most recently
from
7f3f56f to
5eb944d
Compare
javierfreire
changed the title
src/action.ts
Outdated
| if (uploadResult.failedItems.length > 0) { | ||
| core.warning(`The following files could not be uploaded: ${uploadResult.failedItems}`) | ||
| } | ||
| await artifactClient.uploadArtifact(artifactName, artifacts, baseDir) |
There was a problem hiding this comment.
Can we keep the other functionality somehow? I mean continuing on errors and warning on failed uploads.
There was a problem hiding this comment.
With the v4 all the artifacts are uploaded packed as one file, so that check makes no sense.
There was a problem hiding this comment.
Ok. I see. We need to check for upload errors then. Right now, I believe a glitch on GitHub uploads does not break the action. But with your change, looking at the client library code, a glitch will show a warning but also bubbles up the error which I presume will make our action to fail.
Can you see if this make sense? If it does, think can we can avoid breaking. Overall, artifact upload is a nice to have, if it fails we still want to have the action succeed.
There was a problem hiding this comment.
Done, I added a try/catch to handle the error
javierfreire
force-pushed
the
artifact-actions-v4
branch
2 times, most recently
from
57f9d8c to
1c6497b
Compare
Signed-off-by: Javier Friere <javier.freire@broadcom.com>
javierfreire
force-pushed
the
artifact-actions-v4
branch
from
1c6497b to
62712d0
Compare
|
This PR is replaced by the PR |
No description provided.