This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #749 Signed-off-by: Vui Lam <vui@vmware.com>
- Loading branch information
Showing
1 changed file
with
39 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,54 @@ | ||
**What this PR does / why we need it**: | ||
### What this PR does / why we need it | ||
|
||
**Which issue(s) this PR fixes**: | ||
### Which issue(s) this PR fixes | ||
<!-- | ||
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. | ||
Usage: Fixes #<issue number>. | ||
Unless the PR is for a trivial change (e.g. fixing a typo), consider opening an issue first | ||
(and reference it here) so that the problem the PR addresses can be discussed independently of | ||
the solutions proposed by this PR. | ||
--> | ||
|
||
Fixes # | ||
|
||
**Describe testing done for PR**: | ||
<!-- | ||
Example: Created vSphere workload cluster to verify change. | ||
--> | ||
### Describe testing done for PR | ||
|
||
**Special notes for your reviewer**: | ||
<!-- Example: Created vSphere workload cluster to verify change. --> | ||
|
||
**Release note**: | ||
### Release note | ||
<!-- | ||
See https://github.com/vmware-tanzu/tanzu-framework/blob/main/docs/release/release-notes.md#does-my-pull-request-need-a-release-note | ||
for more details. | ||
Please add a short text (limit to 1 to 2 sentences if possible) in the release-note block below if | ||
there is anything in this PR that is worthy of mention in the next release. | ||
Please add a short text in the release-note block below (or "NONE" if not applicable) | ||
if there is anything in this PR that is worthy of mention in the next release. | ||
See https://github.com/vmware-tanzu/tanzu-framework/blob/main/docs/release/release-notes.md#does-my-pull-request-need-a-release-note | ||
for more details. | ||
--> | ||
```release-note | ||
``` | ||
**New PR Checklist** | ||
|
||
- [ ] Ensure PR contains only public links or terms | ||
### PR Checklist | ||
|
||
<!-- Please acknowlege by checking that they are being followed --> | ||
|
||
- [ ] Squash the commits into one or a small number of logical commits | ||
<!-- | ||
This repository adopts a linear git history model where no merge commits are necessary. To | ||
keep the commit history tidy, it is recommended that authors be responsible for the decision | ||
whether to squash the PR's changes into a single commit (and tidy up the commit message in the | ||
process) or organizing them into a small number of self-contained and meaningful ones. | ||
--> | ||
- [ ] Use good commit [messages](https://github.com/vmware-tanzu/tanzu-framework/blob/main/CONTRIBUTING.md) | ||
- [ ] Squash the commits in this branch before merge to preserve our git history | ||
- [ ] If this PR is just an idea or POC, use a [Draft PR](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests#draft-pull-requests) instead of a full PR | ||
- [ ] Add appropriate [kind label](../docs/release/kind-labels.md) according to what type of issue is being addressed. | ||
- [ ] Ensure PR contains terms all contributors can understand and links all contributors can access | ||
|
||
|
||
### Additional information | ||
|
||
#### Special notes for your reviewer | ||
|
||
<!-- Add notes to that can aid in the review process, or leave blank --> | ||
|
||
<!-- | ||
If this pull request is just an idea or POC, or is not ready for review, select "Create draft pull request" (https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests#draft-pull-requests) | ||
instead of "Create pull request" | ||
--> |