Make SetVolumeID function support cross-project scenario. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
SetVolumID_support_cross_project
branch
from
2d8a53b
to
ee11e20
Compare
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 27.00% 29.26% +2.26%
==========================================
Files 3 3
Lines 500 516 +16
==========================================
+ Hits 135 151 +16
Misses 353 353
Partials 12 12
|
ywk253100
approved these changes
Jul 27, 2023
shubham-pampattiwar
approved these changes
Jul 27, 2023
|
Nice! 👏 Will this get backported? I've hit this issue with latest stable 1.11.1 vmware-tanzu/velero#6021 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for vmware-tanzu/velero#6038.