fix: Remove duplicated stale job #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
.github/workflows/stale-issues.yml
Outdated
| @@ -13,12 +12,15 @@ jobs: | |||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | |||
| stale-issue-message: "This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. If a Velero team member has requested log or more information, please provide the output of the shared commands." | |||
| close-issue-message: "This issue was closed because it has been stalled for 5 days with no activity." | |||
| days-before-issue-stale: 30 | |||
| days-before-issue-close: 5 | |||
| days-before-issue-stale: 30 # 60 | |||
There was a problem hiding this comment.
we keep the days of the other job?
There was a problem hiding this comment.
My opinion is to use the longer setting.
.github/workflows/stale-issues.yml
Outdated
| # Disable stale PRs for now; they can remain open. | ||
| days-before-pr-stale: -1 | ||
| days-before-pr-close: -1 | ||
| # Only issues made after Feb 09 2021. | ||
| start-date: "2021-09-02T00:00:00" | ||
| # Only make issues stale if they have these labels. Comma separated. | ||
| only-labels: "Needs info,Duplicate" | ||
| # only-labels: "Needs info,Duplicate" |
There was a problem hiding this comment.
Only labels work like a "AND", not a "OR", so only issues that have both these labels would be marked as staled. More info
I think keeping what the old job was doing with exempt-issue-labels is good
| days-before-issue-close: 5 | ||
| days-before-issue-stale: 30 # 60 | ||
| days-before-issue-close: 5 # 14 | ||
| stale-issue-label: staled | ||
| # Disable stale PRs for now; they can remain open. | ||
| days-before-pr-stale: -1 |
There was a problem hiding this comment.
I like the idea of just marking issues as staled, but not PRs
blackpiglet
added
the
kind/changelog-not-required
Codecov Report
@@ Coverage Diff @@
## main #6416 +/- ##
==========================================
+ Coverage 53.77% 53.81% +0.03%
==========================================
Files 228 228
Lines 23777 23777
==========================================
+ Hits 12787 12795 +8
+ Misses 10043 10036 -7
+ Partials 947 946 -1 |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
blackpiglet
previously approved these changes
Jun 27, 2023
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
blackpiglet
approved these changes
Jun 30, 2023
sseago
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Remove duplicated stale job from project.
Does your change fix a particular issue?
Fixes #6386
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.