Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tilt ubuntu image to avoid glibc error #6430

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

anshulahuja98
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Ubuntu: focal operates on slightly older versions. It has glibc version 2.31 as compared to newer OS use 2.35.

This leads to issues in the pod coming up, the pod keeps crashing with error message cribbing that the appropriate glibc version was not found.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@anshulahuja98
Copy link
Collaborator Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jun 28, 2023
Tiltfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #6430 (cc76bc0) into main (de83980) will increase coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6430      +/-   ##
==========================================
+ Coverage   58.41%   59.18%   +0.76%     
==========================================
  Files         227      229       +2     
  Lines       23771    24193     +422     
==========================================
+ Hits        13887    14319     +432     
+ Misses       8899     8875      -24     
- Partials      985      999      +14     

see 15 files with indirect coverage changes

@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Jun 29, 2023
Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>
@anshulahuja98
Copy link
Collaborator Author

Squashed commit and fixed DCO, addressed PR comment.
Ready to check- in

@anshulahuja98
Copy link
Collaborator Author

@ywk253100 can you pl review/ approve this.

@shubham-pampattiwar shubham-pampattiwar merged commit d2b5e90 into vmware-tanzu:main Jul 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants