Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance test code frame #6495

Closed
wants to merge 2 commits into from

Conversation

qiuming-best
Copy link
Contributor

@qiuming-best qiuming-best commented Jul 14, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)
#6088

This pr has moved all common libraries in test/e2e into the test path and added one new test/perf path for the performance test
It's one performance test frame that includes:

  • Makefile for the performance test
  • Basic Performance E2E test frame
  • Three basic backup and restore related test cases
  • Metrics about Pod, NFS, Minio
  • Report Generator

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-e2e-tests labels Jul 14, 2023
@qiuming-best qiuming-best marked this pull request as draft July 14, 2023 02:13
@qiuming-best qiuming-best force-pushed the perf-test branch 5 times, most recently from c6796b3 to c385879 Compare July 16, 2023 21:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #6495 (506de12) into main (17d782f) will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6495      +/-   ##
==========================================
+ Coverage   60.03%   60.37%   +0.33%     
==========================================
  Files         229      239      +10     
  Lines       24491    25433     +942     
==========================================
+ Hits        14704    15355     +651     
- Misses       8774     9016     +242     
- Partials     1013     1062      +49     

see 38 files with indirect coverage changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these e2e tests docs are not cited in the website docs, right? Wouldn't be good to cite them there (or even write them there)?

Copy link
Contributor Author

@qiuming-best qiuming-best Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good advice, I'll cite it in the website docs

@qiuming-best qiuming-best force-pushed the perf-test branch 4 times, most recently from 14f074b to 14ab631 Compare July 18, 2023 07:01
@reasonerjt reasonerjt marked this pull request as ready for review July 19, 2023 08:18
@reasonerjt reasonerjt changed the title Add performance test code frame [WIP]Add performance test code frame Jul 19, 2023
@reasonerjt reasonerjt added this to the v1.12 milestone Jul 19, 2023
@qiuming-best qiuming-best force-pushed the perf-test branch 5 times, most recently from bfc5cc2 to c42181a Compare July 21, 2023 01:32
@qiuming-best qiuming-best changed the title [WIP]Add performance test code frame Add performance test code frame Jul 21, 2023
@@ -0,0 +1,3 @@
# End-to-end tests

Document for running Velero end-to-end performance test suite.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fill in the documentation later

Signed-off-by: Ming <mqiu@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-e2e-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants