Fix issue 6561 #6564
Merged
Fix issue 6561 #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyndon-Li
added
the
kind/changelog-not-required
sseago
previously approved these changes
Jul 31, 2023
Lyndon-Li
force-pushed
the
issue-fix-6561-02
branch
2 times, most recently
from
28fecc1
to
3ad4f8b
Compare
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Lyndon-Li
force-pushed
the
issue-fix-6561-02
branch
from
3ad4f8b
to
d6134ec
Compare
There was a problem hiding this comment.
would be interesting to use cobra here? it would be more verbose, but we would have a CLI by default (and it also have the 2 validations builtin: cobra.MinimumNArgs(1) and cobra.OnlyValidArgs
There was a problem hiding this comment.
I am hesitating to involve cobra:
- The binary is targeted to implement simply tasks (otherwise, we can use velero binary instead), i.e., the current pause functionality, it is not expected to be with complex parameters, for which cobra could make a big help.
- Involving cobra will involve some more packages, which will make the total binary size larger.
There was a problem hiding this comment.
We may even make it simpler to make it velero-pause, b/c I don't think we wanna support other subcommand, it's simply a placeholder for DM.
|
We have more inputs/requirements today, so changed the solution from end to end and see if this can meet them:
|
blackpiglet
approved these changes
Aug 2, 2023
ywk253100
approved these changes
Aug 2, 2023
This was referenced Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6561, change the backup/restore pod's image to the same image used by the node-agent, but with a different binary
velero-helper, so as not to depend on Alpine which may have compliance or security issues or image pull issues.