Fix data mover controller bugs

[qiuming-best]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)
#6615
#6612
#6550
#6563
#6600

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• Updated the corresponding documentation in site/content/docs/main.

[Lyndon-Li]

Don't check for dd.Spec.Cancel but for isDataDownloadInFinalState(dd).
For all terminal statuses, we need to do this, e.g., when prepare timeout happens, the CR will be set to Failed instead of Cancelled or dd.Spec.Cancel = true.

[qiuming-best]

Updated

[Lyndon-Li]

The same, check for isDataUploadInFinalState(du)

[qiuming-best]

Updated

[Lyndon-Li]

ExclusiveUpdateDataUpload is a fundermental function, we don't expect all the callers expect a updated du, so it is risky to update the du directly.

Actually, I suggest we leave ExclusiveUpdateDataUpload as is, and change the function of acceptDataUpload, the latter is more pure and it is safe to change it.

[qiuming-best]

I've changed back to exclusiveUpdateDataUpload.

But for this function, in the update action, it is not a general usage that coping it before updating, leading to many related UT tests failing with conflict errors.

So I removed the DeepCopy function for the UT, I know your original purpose would be not willing to update the du directly, but for our current usage scenario there is no effect as we always get the latest CR from the API server instead of memory in each Reconcile

[codecov]

Codecov Report

Merging #6616 (5485616) into main (06628cf) will increase coverage by 0.13%.
Report is 27 commits behind head on main.
The diff coverage is 61.88%.

@@            Coverage Diff             @@
##             main    #6616      +/-   ##
==========================================
+ Coverage   60.18%   60.31%   +0.13%     
==========================================
  Files         242      242              
  Lines       25639    25924     +285     
==========================================
+ Hits        15431    15637     +206     
- Misses       9135     9186      +51     
- Partials     1073     1101      +28     

Files Changed	Coverage Δ
pkg/cmd/cli/nodeagent/server.go	8.91% <0.00%> (-0.12%)	⬇️
pkg/cmd/server/server.go	21.80% <0.00%> (-0.12%)	⬇️
pkg/controller/data_upload_controller.go	68.25% <63.51%> (+2.28%)	⬆️
pkg/controller/data_download_controller.go	75.18% <73.45%> (+1.08%)	⬆️

... and 10 files with indirect coverage changes