Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pod with deployment for E2E test #6684

Conversation

danfengliu
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@danfengliu danfengliu added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Aug 21, 2023
@danfengliu danfengliu force-pushed the fix-storage-class-failure-issue branch 2 times, most recently from 626f6d5 to e56b860 Compare August 23, 2023 09:01
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #6684 (da5f403) into release-1.11 (2e5aeb7) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head da5f403 differs from pull request most recent head a35d7b4. Consider uploading reports for the commit a35d7b4 to get more accurate results

@@               Coverage Diff                @@
##           release-1.11    #6684      +/-   ##
================================================
+ Coverage         41.28%   41.30%   +0.02%     
================================================
  Files               251      251              
  Lines             23436    23436              
================================================
+ Hits               9676     9681       +5     
+ Misses            13001    12996       -5     
  Partials            759      759              

see 1 file with indirect coverage changes

@danfengliu danfengliu force-pushed the fix-storage-class-failure-issue branch from e56b860 to 4fc0a6a Compare August 24, 2023 00:57
@danfengliu danfengliu marked this pull request as ready for review August 24, 2023 07:04
@danfengliu danfengliu requested review from blackpiglet and qiuming-best and removed request for reasonerjt and ywk253100 August 24, 2023 07:05
blackpiglet
blackpiglet previously approved these changes Aug 24, 2023
blackpiglet
blackpiglet previously approved these changes Aug 25, 2023
@danfengliu danfengliu force-pushed the fix-storage-class-failure-issue branch 2 times, most recently from a35d7b4 to 8de2c8c Compare August 25, 2023 02:35
Signed-off-by: danfengl <danfengl@vmware.com>
@danfengliu danfengliu force-pushed the fix-storage-class-failure-issue branch from 8de2c8c to 6ef013d Compare August 25, 2023 07:46
@danfengliu danfengliu merged commit e6b510e into vmware-tanzu:release-1.11 Aug 25, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants