Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CherryPick v1.12] Fix delete dataupload datadownload CR failure #6701

Merged

Conversation

qiuming-best
Copy link
Contributor

Fix delete dataupload datadownload CR failure when Velero uninstall

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)
#6687

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

…lero uninstall

Signed-off-by: Ming <mqiu@vmware.com>
@qiuming-best qiuming-best added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #6701 (5480acf) into release-1.12 (e2d3e84) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release-1.12    #6701   +/-   ##
=============================================
  Coverage         60.36%   60.36%           
=============================================
  Files               242      242           
  Lines             25979    25979           
=============================================
  Hits              15683    15683           
  Misses             9194     9194           
  Partials           1102     1102           
Files Changed Coverage Δ
pkg/controller/data_download_controller.go 75.18% <100.00%> (ø)
pkg/controller/data_upload_controller.go 68.25% <100.00%> (ø)

@qiuming-best qiuming-best merged commit 5f585be into vmware-tanzu:release-1.12 Aug 25, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants