Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On restore, delete Kubernetes 1.27 job controller uid label #6712

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Aug 28, 2023

  • Handle 1.27 k8s job label changes
  • changelog

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6711

release-1.12 PR #6713

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

…nown

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai changed the title jobs label k8s1.27 On restore, delete Kubernetes 1.27 job controller uid label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #6712 (c5aad9e) into main (831be07) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6712      +/-   ##
==========================================
+ Coverage   60.33%   60.36%   +0.03%     
==========================================
  Files         242      242              
  Lines       25982    25984       +2     
==========================================
+ Hits        15675    15685      +10     
+ Misses       9203     9196       -7     
+ Partials     1104     1103       -1     
Files Changed Coverage Δ
pkg/restore/job_action.go 56.52% <100.00%> (+4.14%) ⬆️

... and 1 file with indirect coverage changes

@reasonerjt reasonerjt merged commit cf3cb9c into vmware-tanzu:main Sep 18, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.27 job controller uid label not getting deleted on restore
3 participants