Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12] Cherry Pick - add label selector in Resource Modifiers (#6704) #6725

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

anshulahuja98
Copy link
Collaborator

  • add label selector in resource modifier

  • add ut

  • update after review

  • update after review


Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

* add label selector in resource modifier

Signed-off-by: lou <alex1988@outlook.com>

* add ut

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

* update after review

Signed-off-by: lou <alex1988@outlook.com>

---------

Signed-off-by: lou <alex1988@outlook.com>
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #6725 (4516550) into release-1.12 (5353013) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

@@               Coverage Diff                @@
##           release-1.12    #6725      +/-   ##
================================================
- Coverage         60.36%   60.36%   -0.01%     
================================================
  Files               242      242              
  Lines             25979    25983       +4     
================================================
+ Hits              15683    15684       +1     
- Misses             9194     9196       +2     
- Partials           1102     1103       +1     
Files Changed Coverage Δ
internal/resourcemodifiers/resource_modifiers.go 75.65% <66.66%> (-1.83%) ⬇️
.../resourcemodifiers/resource_modifiers_validator.go 100.00% <100.00%> (ø)

@reasonerjt reasonerjt merged commit 90bc1ab into vmware-tanzu:release-1.12 Aug 31, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants