-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kopia/repository/config/aws.go: Set session.Options profile from config #6995
Merged
shubham-pampattiwar
merged 1 commit into
vmware-tanzu:main
from
kaovilai:kopias3profilecred
Oct 30, 2023
Merged
kopia/repository/config/aws.go: Set session.Options profile from config #6995
shubham-pampattiwar
merged 1 commit into
vmware-tanzu:main
from
kaovilai:kopias3profilecred
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
kopias3profilecred
branch
from
October 20, 2023 18:07
34bf64d
to
d04b26e
Compare
1 task
Codecov Report
@@ Coverage Diff @@
## main #6995 +/- ##
=======================================
Coverage 61.04% 61.05%
=======================================
Files 252 252
Lines 26854 26856 +2
=======================================
+ Hits 16394 16396 +2
Misses 9305 9305
Partials 1155 1155
|
kaovilai
force-pushed
the
kopias3profilecred
branch
from
October 20, 2023 18:38
d04b26e
to
6eb47cf
Compare
Lyndon-Li
reviewed
Oct 24, 2023
Lyndon-Li
previously approved these changes
Oct 24, 2023
3 tasks
kaovilai
force-pushed
the
kopias3profilecred
branch
2 times, most recently
from
October 24, 2023 18:03
1528d8b
to
eaba951
Compare
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
kopias3profilecred
branch
from
October 24, 2023 18:05
eaba951
to
d5f238c
Compare
Lyndon-Li
approved these changes
Oct 25, 2023
sseago
approved these changes
Oct 30, 2023
shubham-pampattiwar
approved these changes
Oct 30, 2023
shubham-pampattiwar
merged commit Oct 30, 2023
03e582c
into
vmware-tanzu:main
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
non default s3 credential profiles work again after #6598
Does your change fix a particular issue?
Fixes #6996
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.