Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Expose PVPatchMaximumDuration timeout for custom configuration #8035

Conversation

shubham-pampattiwar
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #8020

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

remove debug log

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

use resource timeout server arg

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add changelog

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

remove hardcoded PVPatchMaximumtimeout const usagDe

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
(cherry picked from commit fd6c747)

update changelog filename

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
@shubham-pampattiwar shubham-pampattiwar force-pushed the expose-pv-patch-max-timeout-rel-1.14 branch from 119b265 to fea6316 Compare July 22, 2024 15:27
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (6ae34a1) to head (fea6316).

Files Patch % Lines
pkg/cmd/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.14    #8035   +/-   ##
=============================================
  Coverage         58.77%   58.77%           
=============================================
  Files               346      346           
  Lines             28818    28821    +3     
=============================================
+ Hits              16938    16940    +2     
- Misses            10451    10452    +1     
  Partials           1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-pampattiwar shubham-pampattiwar changed the title Expose PVPatchMaximumDuration timeout for custom configuration [release-1.14] Expose PVPatchMaximumDuration timeout for custom configuration Jul 22, 2024
@Lyndon-Li Lyndon-Li merged commit ebafe12 into vmware-tanzu:release-1.14 Jul 23, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants