Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use labels instead of regex to filter E2E test cases. #8038

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 23, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7958
Fixes #7959

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 23, 2024
@blackpiglet blackpiglet self-assigned this Jul 23, 2024
@blackpiglet blackpiglet force-pushed the 7959_fix branch 2 times, most recently from d9db13f to 534922e Compare July 23, 2024 06:47
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.79%. Comparing base (442cc76) to head (71c75d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8038   +/-   ##
=======================================
  Coverage   58.79%   58.79%           
=======================================
  Files         349      349           
  Lines       29063    29063           
=======================================
  Hits        17089    17089           
  Misses      10542    10542           
  Partials     1432     1432           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/e2e/README.md Outdated Show resolved Hide resolved
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
test/e2e/README.md Outdated Show resolved Hide resolved
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
@blackpiglet
Copy link
Contributor Author

@kaovilai @sseago
Modified. PTAL.

Copy link
Contributor

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blackpiglet blackpiglet merged commit c2bc67b into vmware-tanzu:main Jul 26, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
5 participants