Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the E2E and performance test timeout to 5 hours #8039

Closed
wants to merge 2 commits into from

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 23, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7958

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 23, 2024
@blackpiglet blackpiglet self-assigned this Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.82%. Comparing base (2bf3bc9) to head (c6d3380).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8039   +/-   ##
=======================================
  Coverage   58.82%   58.82%           
=======================================
  Files         346      346           
  Lines       28892    28892           
=======================================
  Hits        16995    16995           
  Misses      10468    10468           
  Partials     1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

After bumping Ginkgo to v2, the default timeout is 1h, which is not
enough for now. Set the timeout for both of them to 5h.

Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to set the E2E test timeout after bumping Ginkgo to v2
1 participant