Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow make local to work without docker in path #8056

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Jul 29, 2024

No longer hangs without docker in path

❯ which docker; time make local
docker not found
GOOS=darwin \
        GOARCH=arm64 \
        GOBIN=$(pwd)/.go/bin \
        VERSION=main \
        REGISTRY=velero \
        PKG=github.com/vmware-tanzu/velero \
        BIN=velero \
        GIT_SHA=9172ba88c8aaebfdd56751818ceabfaad48752b2 \
        GIT_TREE_STATE=clean \
        OUTPUT_DIR=$(pwd)/_output/bin/darwin/arm64 \
        ./hack/build.sh
make local  0.78s user 1.27s system 241% cpu 0.847 total

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #8055 (issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.88%. Comparing base (d9ca147) to head (d6f89e2).
Report is 164 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8056   +/-   ##
=======================================
  Coverage   58.88%   58.88%           
=======================================
  Files         351      351           
  Lines       29367    29367           
=======================================
  Hits        17294    17294           
  Misses      10639    10639           
  Partials     1434     1434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaovilai kaovilai force-pushed the makelocalnodocker branch 6 times, most recently from 8cc4e57 to 31a1837 Compare July 29, 2024 03:55
@kaovilai kaovilai marked this pull request as draft July 29, 2024 03:55
@kaovilai kaovilai force-pushed the makelocalnodocker branch 2 times, most recently from 3966748 to c5fb3a4 Compare July 29, 2024 04:04
@kaovilai
Copy link
Contributor Author

Note that > file 2>&1 is an older syntax which still works, &> file is neater, but would not have worked on older systems.

whoops.. guess older syntax it is for github actions.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai marked this pull request as ready for review July 29, 2024 04:10
@github-actions github-actions bot requested a review from reasonerjt July 29, 2024 04:11
@reasonerjt reasonerjt merged commit 10260bd into vmware-tanzu:main Oct 9, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make local fails if docker is not installed
4 participants