Merge pull request #3233 from dougm/issue-3221

vcsim: set HostSystem.Config.Host
vmware · Sep 28, 2023 · 20719b2 · 20719b2
2 parents f859a94 + d49e401
commit 20719b2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/simulator/cluster_compute_resource.go b/simulator/cluster_compute_resource.go
@@ -70,6 +70,7 @@ func (add *addHost) Run(task *Task) (types.AnyType, types.BaseMethodFault) {
 
 	task.ctx.Map.PutEntity(cr, task.ctx.Map.NewEntity(host))
 	host.Summary.Host = &host.Self
+	host.Config.Host = host.Self
 
 	cr.Host = append(cr.Host, host.Reference())
 	addComputeResource(cr.Summary.GetComputeResourceSummary(), host)

diff --git a/simulator/host_system.go b/simulator/host_system.go
@@ -486,6 +486,7 @@ func CreateStandaloneHost(ctx *Context, f *Folder, spec types.HostConnectSpec) (
 
 	ctx.Map.PutEntity(cr, ctx.Map.NewEntity(host))
 	host.Summary.Host = &host.Self
+	host.Config.Host = host.Self
 
 	ctx.Map.PutEntity(cr, ctx.Map.NewEntity(pool))
 

diff --git a/simulator/host_system_test.go b/simulator/host_system_test.go
@@ -26,6 +26,7 @@ import (
 	"github.com/vmware/govmomi/find"
 	"github.com/vmware/govmomi/object"
 	"github.com/vmware/govmomi/simulator/esx"
+	"github.com/vmware/govmomi/vim25"
 	"github.com/vmware/govmomi/vim25/types"
 )
 
@@ -70,6 +71,18 @@ func TestDefaultESX(t *testing.T) {
 	}
 }
 
+func TestDefaultVPX(t *testing.T) {
+	Test(func(ctx context.Context, c *vim25.Client) {
+		for _, e := range Map.All("HostSystem") {
+			host := e.(*HostSystem)
+			// issue #3221
+			if host.Config.Host != host.Self {
+				t.Errorf("config.host=%s", host.Config.Host)
+			}
+		}
+	})
+}
+
 func TestMaintenanceMode(t *testing.T) {
 	ctx := context.Background()
 	m := ESX()