Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When passing an endpoint as
https://some.vcenter.tld/
to govc (or soap client), it will consider the leading / as part of the path and not add the/sdk
.This leads to errors when consuming vCenter API.
While passing the leading "/" may be desired, I'm not sure if there's a better way to turn this error more intuitive.
This PR also adds some unit tests on ParseURL function
Closes: #(issue-number)
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.
https://some.vcenter.tld
with and without the leading path. Without the change, it always gets an unauthorized accessChecklist:
CONTRIBUTION
guidelines of this project