Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datacenter output on govc #3218

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Aug 24, 2023

Description

govc datacenter.info is printing the wrong VM count, as it is doing the query based on root folder and not on the used datacenter reference.

This way, with multiple datacenters the count will be always the total of VMs regardless of what datacenter they are, instead of a per dc count.

This PR fixes this count, setting the right property on Containerview to use the datacenter and not the root folder

Closes: #(issue-number)

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Test Description 1
  • Test Description 2

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rikatz , lgtm, but can you fixup the commit message , something like:

fix: govc datacenter.info VM count with multiple DCs

@rikatz
Copy link
Contributor Author

rikatz commented Aug 24, 2023

done :)

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rikatz !

@rikatz rikatz merged commit 72d86e9 into vmware:main Aug 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants