govc: add native kms provider support #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
force-pushed
the
kms-native
branch
4 times, most recently
from
01fd0c0
to
9695454
Compare
akutz
previously approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Looks great @dougm , as usual. Thank you! My only feedback is that it stinks we cannot align the crypto and vapi/crypto packages a little better. But I guess in the end it makes more sense to keep them aligned with the actual APIs. I wonder if we should add a README.md to the crypto package (and vice versa) that indicates to users where to look for the different types of crypto logic.
Extracted from govc namespace.cluster.logs for general use.
akutz
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api: add vapi/crypto package with support for native KMS
api: add rest.Client.DownloadAttachment method