api: disable http.Transport.ForceAttemptHTTP2 by default #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
force-pushed
the
disable-http2
branch
from
278a5ed
to
6c91474
Compare
RPitt
approved these changes
Oct 1, 2024
mayankbh
reviewed
Oct 1, 2024
vim25/soap/client.go
Outdated
Comment on lines
165
to
166
| if insecure { | ||
| if t.TLSClientConfig == nil { | ||
| t.TLSClientConfig = new(tls.Config) | ||
| } | ||
| t.TLSClientConfig.InsecureSkipVerify = insecure |
There was a problem hiding this comment.
nit: is this if redundant?
Revert soap.Client http.Transport back to manual construction, rather than Clone() (see 313aa85) Disable ForceAttemptHTTP2 by default, as we currently see degraded transfer rates with large file uploads. Closes vmware#3564
mayankbh
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert soap.Client http.Transport back to manual construction, rather than Clone() (see 313aa85)
Disable ForceAttemptHTTP2 by default, as we currently see degraded transfer rates with large file uploads.
Closes #3564