Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set DuplicateName Object to duplicate object #3612

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

prziborowski
Copy link
Contributor

Closes: #3610

Description

Updates the simulator CreateFolder / CreateStoragePod to set the DuplicateName's Object to the existing one, instead of the Folder the operation is called on.

Closes: #3610

How Has This Been Tested?

Added unit test, and run with and without the fix.

Guidelines

Please read and follow the CONTRIBUTION guidelines of this project.

Closes: vmware#3610
Signed-off-by: Nathan Prziborowski <prziborowski@gmail.com>
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @prziborowski !

@prziborowski prziborowski merged commit 455de3e into vmware:main Nov 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] simulator: Object of DuplicateName fault of CreateFolder is incorrect
2 participants