Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revise settings for vmware-user.desktop #668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polarathene
Copy link

This file has barely been touched since 2009, a little maintenance is warranted:

This file has barely been touched since 2009, a little maintenance is warranted:
- `Encoding` key is deprecated, drop it.
- The referenced bug for `NoDisplay=true` was closed long ago (2012).
@vmwclabot
Copy link
Member

@polarathene, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@polarathene, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@polarathene, VMware has approved your signed contributor license agreement.

@polarathene
Copy link
Author

@jonathanvmw Could this be marked for review too please? Seems an easy enough improvement to get approved and merged?

@polarathene
Copy link
Author

Friendly ping, this should be fairly easy contribution to review and approve...?

@jonathanvmw
Copy link
Contributor

@polarathene - Thanks for the ping. Will try to get some attention on this.

vmwkruti1111 added a commit that referenced this pull request Jul 16, 2024
Update settings for vmware-user.desktop.in:
- Remove Encoding since it's deprecated.
- Uncomment NoDisplay=True since the bug related to it was fixed
a while ago.

Delete bora-vmsoft/install/common/vmware-user.desktop as it is no
longer needed. In open-vm-tools, vmware-user.desktop is generated from
vmware-user.desktop.in.

Pull request: #668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants