Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sizeof('c')=4, not 1: fix read-past-the-end/overallocation #700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nabijaczleweli
Copy link

@vmwclabot
Copy link
Member

@nabijaczleweli, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@nabijaczleweli, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@nabijaczleweli
Copy link
Author

The same query also reveals

1014    int vixPrefixDataSize = (MAX64_DECIMAL_DIGITS * 2)
1015                              + (sizeof(' ') * 2)
1016                              + sizeof('\0')
1017                              + sizeof(' ') * 10;   // for RPC header
"open-vm-tools/services/plugins/vix/foundryToolsDaemon.c" 1133 lines --89%--                                                                              1010,1        89%

but without any context I cannot assess if this is also a mistake (most likely yes).

@vmwclabot
Copy link
Member

@nabijaczleweli, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants