feat: add remote ovf/ova source support #580
Draft
+7,946
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
added
enhancement
tenthirtyam
force-pushed
the
feat/remote-ovf-clone-source
branch
2 times, most recently
from
d0b7a85 to
392c0a9
Compare
tenthirtyam
changed the title
There was a problem hiding this comment.
Pull request overview
This PR extends the vsphere-clone builder to support deploying VMs from remote OVF/OVA files accessible via HTTP/HTTPS URLs, in addition to the existing template-based cloning. The implementation uses vSphere's native OVF Manager capabilities and includes comprehensive validation, authentication support, TLS configuration, credential sanitization, and extensive test coverage.
Key Changes:
- Adds
remote_sourceconfiguration block with URL, authentication credentials, and TLS options - Implements mutual exclusivity between
templateandremote_source - Adds OVF deployment functionality in the driver layer with progress monitoring
- Includes comprehensive credential sanitization to prevent exposure in logs and error messages
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
builder/vsphere/clone/step_clone.go |
Adds RemoteSourceConfig struct, OVF deployment logic, and credential sanitization |
builder/vsphere/driver/driver.go |
Implements OVF deployment, progress monitoring, error handling, and validation |
builder/vsphere/driver/driver_mock.go |
Adds mock implementations for OVF operations |
builder/vsphere/driver/driver_test.go |
Comprehensive tests for OVF functionality |
builder/vsphere/clone/step_clone_test.go |
Tests for remote source detection and deployment |
builder/vsphere/clone/config.go |
Updates code generation directive |
docs-partials/**/*.mdx |
Documentation for remote source configuration |
| Test files | HTTP server, integration tests, and credential handling tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tenthirtyam
force-pushed
the
feat/remote-ovf-clone-source
branch
2 times, most recently
from
11f4a7c to
8b1e9e3
Compare
Extends the `vsphere-clone` builder to support using remote OVF and OVA files as clone sources, in addition to the current support for standard virtual machine templates. Remote OVF/OVA support enables users to deploy virtual machines directly from OVF/OVA files accessible via HTTP/HTTPS URLs using vSphere's native OVF Manager capabilities available in the `vmware/govmomi` SDK. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.otg>
tenthirtyam
force-pushed
the
feat/remote-ovf-clone-source
branch
from
8b1e9e3 to
605173b
Compare
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning
End-to-end testing is still pending.
Extends the
vsphere-clonebuilder to support using remote OVF and OVA files as clone sources, in addition to the current support for standard virtual machine templates. Remote OVF/OVA support enables users to deploy virtual machines directly from OVF/OVA files accessible via HTTP/HTTPS URLs using vSphere's native OVF Manager capabilities available in thevmware/govmomiSDK.It adds a new
remote_sourceconfiguration block, updates documentation, and implements comprehensive validation and tests to ensure correct usage and mutual exclusivity betweentemplateandremote_source.Resolved Issues
Closes #566
Rollback Plan
Revert commit.
Changes to Security Controls
None.