Merged
Conversation
tigershi
requested review from
Xiaochao8,
huihuiw01,
jin-jasper and
linr211
and removed request for
huihuiw01 and
linr211
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2889 +/- ##
============================================
+ Coverage 52.48% 52.55% +0.07%
- Complexity 394 400 +6
============================================
Files 68 70 +2
Lines 2376 2388 +12
Branches 293 293
============================================
+ Hits 1247 1255 +8
- Misses 968 972 +4
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
What are the main differences between TranslationCache3 and SingletonCache? (trying to figure out why make the the replacement.) |
Contributor
Author
|
There has a switch in SingletonCache, In function side, the SingletonCache is as same as TranslationCache3 |
linr211
approved these changes
Dec 20, 2023
jin-jasper
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2883