Skip to content

Support service entries in policy rules #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Support service entries in policy rules #1504

merged 1 commit into from
Feb 10, 2025

Conversation

annakhm
Copy link
Contributor

@annakhm annakhm commented Jan 15, 2025

This follows API change on NSX that allows to specify explicit service entries on rule, as an alternative to service path.

@vmwclabot
Copy link

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Jan 15, 2025
@annakhm annakhm linked an issue Jan 17, 2025 that may be closed by this pull request
Possibility to create firewall rules with protocol and port #1135
Closed
@vmwclabot
Copy link

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@annakhm
Copy link
Contributor Author

annakhm commented Jan 23, 2025

/test-all

ksamoray
ksamoray approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's rebase this and put order in the commit list to resolve the DCO complaint :)

@annakhm
Copy link
Contributor Author

annakhm commented Feb 1, 2025

/test-all

@annakhm annakhm removed the dco-required DCO Required label Feb 1, 2025
@annakhm
Copy link
Contributor Author

annakhm commented Feb 6, 2025

/test-all

Support service entries in policy rules
00e701f 
This follows API change on NSX that allows to specify
explicit service entries on rule, as an alternative to
service path.

Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
@annakhm
Copy link
Contributor Author

annakhm commented Feb 7, 2025

/test-all

salv-orlando
salv-orlando approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annakhm annakhm merged commit aaa2c5f into master Feb 10, 2025
12 checks passed
@annakhm annakhm deleted the service-entries branch February 10, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salv-orlando salv-orlando salv-orlando approved these changes

@ksamoray ksamoray ksamoray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to create firewall rules with protocol and port
4 participants
@annakhm @vmwclabot @salv-orlando @ksamoray