-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JOSS paper. #43
base: develop
Are you sure you want to change the base?
Add JOSS paper. #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vnmabus Thank you! I have added a description of the writing functionality and some general suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with all your suggestions. I commit them and will re-read the article to see if more improvements need to be made. I suggest you to do the same if/when you have time.
Co-authored-by: Tuomas Rossi <34502776+trossi@users.noreply.github.com>
Thank you! I added the changes related to discussion on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a small suggestion including references to NumPy and Pandas publications.
Accepted changes from code review: - Updated references - Set Zenodo DOIs to "all versions" DOI - Add references to NumPy and Pandas Co-authored-by: Tuomas Rossi <34502776+trossi@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #43 +/- ##
===========================================
+ Coverage 89.20% 93.98% +4.78%
===========================================
Files 10 17 +7
Lines 1176 1629 +453
===========================================
+ Hits 1049 1531 +482
+ Misses 127 98 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just re-read the article again and added some suggestions. Please @trossi give me your opinion on these when you have time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vnmabus I agree with all your suggestions. I added a few comments and small suggestions.
Co-authored-by: Tuomas Rossi <34502776+trossi@users.noreply.github.com>
Co-authored-by: Tuomas Rossi <34502776+trossi@users.noreply.github.com>
Co-authored-by: Tuomas Rossi <34502776+trossi@users.noreply.github.com>
Co-authored-by: Tuomas Rossi <34502776+trossi@users.noreply.github.com>
@trossi , I just sent the submission to JOSS. |
@vnmabus Great! Thank you! |
@trossi In case you need it for your CV: it seems that the article was fast-tracked... well, really fast 😅️: https://joss.theoj.org/papers/10.21105/joss.07540 I will merge this and make the necessary edits in the repo in the following days. |
@vnmabus Great, thank you! |
Describe the proposed changes
This adds a paper to the repo, so that we can submit it to JOSS.
@trossi I had to rewrite part of the text that I had, as it was for an older version (prior to pyOpenSci submission). It can probably (almost surely, I would say) be improved, in case you have suggestions to do so.
Other things to take into account:
You can add your changes either as suggestions to this PR or as PRs against this branch.