Improve windows intel detection for Windows 11 #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly expands the range of likely addresses for DTBs (we've found some that start lower than 0x650000) and they also seem to have a dummy DTB with only a couple of entries, which are hit and accepted before the actual DTB is tested. This patch ignores any potential DTBs that have very few entries (less than 96 changed bytes across the entire page).
Both these values may require tuning (lowering the false positive detector, or increasing the lower limit that likely DTBs live at). Without a correct DTB, scanning for the kernel will likely always fail the sanity tests, which is why our backup plans weren't finding the kernel, they were working on a broken translation layer.