[Docker] add downloader and runtime Dockerfiles with build instructions

[zhiweideren]

What type of PR is this?
cleanup

What this PR does / why we need it:

Summarize all the Docker images in the project

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[gemini-code-assist]

Summary of Changes

Hello @zhiweideren, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the Docker image build process by separating the downloader and runtime components into their own dedicated Dockerfiles. This change enhances the modularity and maintainability of the build system, with corresponding updates to the Makefile to support the new build and push workflows. Additionally, minor terminology adjustments were made in CRD definitions and documentation to improve clarity.

Highlights

• Dockerfile Refactoring: The monolithic python/Dockerfile has been split into two dedicated Dockerfiles: docker/Dockerfile.downloader and docker/Dockerfile.runtime. This improves modularity and clarity for building individual components.
• New Dockerfiles for Downloader and Runtime: Introduced docker/Dockerfile.downloader and docker/Dockerfile.runtime to define the build process for these Python-based applications. Both Dockerfiles are based on python:3.12-slim, include installation of curl, unzip, rsync, and AWS CLI v2, and set up the respective application code.
• Makefile Updates for Docker Builds: The Makefile has been updated to include new image variables (IMG_DOWNLOADER, IMG_RUNTIME) and dedicated build targets (docker-build-downloader, docker-build-runtime). The docker-push and docker-buildx targets were also extended to support building and pushing these new downloader and runtime images across multiple platforms.
• Terminology Clarification: Updated descriptions within the CRD definition (workload.serving.volcano.sh_autoscalingpolicybindings.yaml) and its corresponding documentation (workload.serving.volcano.sh.md) to change 'ModelBooster Infer groups' to 'Model Serving groups' for improved consistency and clarity.

Ignored Files

• Ignored by pattern: .github/workflows/** (4)
  • .github/workflows/docker-build-and-push-go.yml
  • .github/workflows/docker-build-and-push-python.yml
  • .github/workflows/docker-build-and-push.yml
  • .github/workflows/python-tests.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Files split, clean and clear, Containers now build with grace, New paths, code takes flight.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully separates the Docker builds for the downloader and runtime components into dedicated Dockerfiles and updates the Makefile to use them. However, the new Dockerfiles introduce some significant security and correctness issues. My review includes detailed comments on Dockerfile.downloader and Dockerfile.runtime with suggestions to use multi-stage builds, run as a non-root user, and fix a critical missing dependency issue. Applying these changes will lead to more secure, smaller, and correct container images.

[zhiweideren]

CI success in forked personal repository

[hzxuzhonghu]

This is duplicate with @git-malu 's pr

[zhiweideren]

yes,ci error. I executed "make generate" based on the latest main branch, and it was auto - generated.

[volcano-sh-bot]

@zhiweideren: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.