The `workerReplicas` parameter has been made an optional field. #655

LiZhenCheng9527 · 2026-01-17T10:24:42Z

What type of PR is this?
/kind enhancement

What this PR does / why we need it:

	// Calculate expected pod count for this role replica
	// Each role replica has 1 entry pod + workerReplicas worker pods
	expectedPods := 1 + int(targetRole.WorkerReplicas)

To:

	// WorkerReplicas defines the number for the worker pod of a role.
	// Required: Need to set the number of worker-pod replicas.
	// +optional
	// +kubebuilder:default=0
	WorkerReplicas *int32 `json:"workerReplicas,omitempty"

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

gemini-code-assist · 2026-01-17T10:25:06Z

Summary of Changes

Hello @LiZhenCheng9527, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the Role API by making the workerReplicas field optional, with a default value of 0. This change allows for simpler configurations where no worker pods are needed, without requiring explicit 0 values. The implementation involved updating the API schema, adapting controller and validation logic to safely handle pointer types, and ensuring all related documentation and tests are consistent with the new optional behavior.

Highlights

API Field Optionality: The workerReplicas field within the Role API definition has been made optional by changing its type from int32 to *int32 and adding +optional and +kubebuilder:default=0 annotations. This means users can now omit this field, and it will default to 0 worker replicas.
Controller Logic Updates: The controller logic responsible for calculating expected pod counts, creating pods, and managing resource requirements has been updated to safely handle the workerReplicas field as a pointer, including necessary nil checks before dereferencing its value.
Validation and Deep Copy Adjustments: The webhook validator functions and the automatically generated deep copy logic have been modified to correctly process the workerReplicas field as a pointer type, ensuring data integrity and proper validation.
Documentation and Test Alignment: The documentation for the workload.serving.volcano.sh CRD has been updated to reflect the new optionality and default value of workerReplicas. Corresponding test cases across various components have also been adjusted to use pointer values or nil for workerReplicas.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request makes the workerReplicas field optional in the Role struct, changing it to a pointer and setting a default value of 0. The changes are propagated throughout the codebase, including controllers, utility functions, and tests, to handle the new pointer type correctly by checking for nil values. My review found a few areas for improvement:

The documentation and code comments for workerReplicas still incorrectly state that the field is required.
There is a typo in a variable name (workerReplicase) in the podgroupmanager.
I've added specific comments with suggestions to address these points. Overall, the change is well-implemented.

gemini-code-assist · 2026-01-17T10:26:58Z

docs/kthena/docs/reference/crd/workload.serving.volcano.sh.md

 | `replicas` _integer_ | The number of a certain role.<br />For example, in Disaggregated Prefilling, setting the replica count for both the P and D roles to 1 results in 1P1D deployment configuration.<br />This approach can similarly be applied to configure a xPyD deployment scenario.<br />Default to 1. | 1 |  |
 | `entryTemplate` _[PodTemplateSpec](#podtemplatespec)_ | EntryTemplate defines the template for the entry pod of a role.<br />Required: Currently, a role must have only one entry-pod. |  |  |
-| `workerReplicas` _integer_ | WorkerReplicas defines the number for the worker pod of a role.<br />Required: Need to set the number of worker-pod replicas. |  |  |
+| `workerReplicas` _integer_ | WorkerReplicas defines the number for the worker pod of a role.<br />Required: Need to set the number of worker-pod replicas. | 0 |  |


The description for workerReplicas still states that it is required. Since this field is now optional with a default value of 0, the documentation should be updated to reflect this change.

Suggested change

| `workerReplicas` _integer_ | WorkerReplicas defines the number for the worker pod of a role.<br />Required: Need to set the number of worker-pod replicas. | 0 | |

| `workerReplicas` _integer_ | WorkerReplicas defines the number for the worker pod of a role.<br />Optional: Defaults to 0 if not specified. | 0 | |

gemini-code-assist · 2026-01-17T10:26:58Z

pkg/apis/workload/v1alpha1/servinggroup_types.go

 	EntryTemplate PodTemplateSpec `json:"entryTemplate"`

 	// WorkerReplicas defines the number for the worker pod of a role.
 	// Required: Need to set the number of worker-pod replicas.


The comment for WorkerReplicas still states that it is required. Since this field is now optional, the comment should be updated to reflect this.

Suggested change

// Required: Need to set the number of worker-pod replicas.

// Optional: Defaults to 0 if not specified.

gemini-code-assist · 2026-01-17T10:26:58Z

pkg/model-serving-controller/podgroupmanager/manager.go

+		workerReplicase := 0
+		if role.WorkerReplicas != nil {
+			workerReplicase = int(*role.WorkerReplicas)
+		}
+		podsPerTask := 1 + workerReplicase // entry + workers


There's a typo in the variable name workerReplicase. It should be workerReplicas.

Suggested change

workerReplicase := 0

if role.WorkerReplicas != nil {

workerReplicase = int(*role.WorkerReplicas)

}

podsPerTask := 1 + workerReplicase // entry + workers

workerReplicas := 0

if role.WorkerReplicas != nil {

workerReplicas = int(*role.WorkerReplicas)

}

podsPerTask := 1 + workerReplicas // entry + workers

gemini-code-assist · 2026-01-17T10:26:58Z

pkg/model-serving-controller/podgroupmanager/manager.go

 		minResources = m.aggregateResources(minResources, &role.EntryTemplate.Spec, expectReplicas)
 		if role.WorkerTemplate != nil {
-			for i := 0; i < int(role.WorkerReplicas); i++ {
+			for i := 0; i < workerReplicase; i++ {


This line uses the variable workerReplicase which has a typo. It should be workerReplicas to match the fix for the variable declaration in the previous hunk.

Suggested change

for i := 0; i < workerReplicase; i++ {

for i := 0; i < workerReplicas; i++ {

hzxuzhonghu

Not sure whta's the motivation. And in k8s the pointer type is to distinguish 0 and nil, it seems 0 and nil is same here

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>

volcano-sh-bot · 2026-01-19T03:53:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lizhencheng9527. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot added the kind/enhancement New feature or request label Jan 17, 2026

volcano-sh-bot requested review from YaoZengzeng, git-malu and hzxuzhonghu January 17, 2026 10:24

volcano-sh-bot added the size/L label Jan 17, 2026

gemini-code-assist bot reviewed Jan 17, 2026

View reviewed changes

LiZhenCheng9527 force-pushed the worker-replicas branch from 83d6db2 to c1a2bfb Compare January 17, 2026 10:29

hzxuzhonghu reviewed Jan 19, 2026

View reviewed changes

The workerReplicas parameter has been made an optional field

472100b

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>

LiZhenCheng9527 force-pushed the worker-replicas branch from d46ebe4 to 472100b Compare January 19, 2026 03:53

volcano-sh-bot added size/S and removed size/L labels Jan 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The `workerReplicas` parameter has been made an optional field. #655

The `workerReplicas` parameter has been made an optional field. #655

Uh oh!

LiZhenCheng9527 commented Jan 17, 2026

Uh oh!

gemini-code-assist bot commented Jan 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

hzxuzhonghu left a comment

Uh oh!

volcano-sh-bot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	\| `workerReplicas` _integer_ \| WorkerReplicas defines the number for the worker pod of a role.<br />Required: Need to set the number of worker-pod replicas. \| 0 \| \|
	\| `workerReplicas` _integer_ \| WorkerReplicas defines the number for the worker pod of a role.<br />Optional: Defaults to 0 if not specified. \| 0 \| \|

	// Required: Need to set the number of worker-pod replicas.
	// Optional: Defaults to 0 if not specified.

	for i := 0; i < workerReplicase; i++ {
	for i := 0; i < workerReplicas; i++ {

The workerReplicas parameter has been made an optional field. #655

Are you sure you want to change the base?

The workerReplicas parameter has been made an optional field. #655

Uh oh!

Conversation

LiZhenCheng9527 commented Jan 17, 2026

Uh oh!

gemini-code-assist bot commented Jan 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

hzxuzhonghu left a comment

Choose a reason for hiding this comment

Uh oh!

volcano-sh-bot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

The `workerReplicas` parameter has been made an optional field. #655

The `workerReplicas` parameter has been made an optional field. #655