Adds support for MySQL publisher. #348
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| ## mbmd and mysql | ||
|
|
||
| Let mbmd write sensor data to mysql | ||
|
|
||
| ### Table | ||
|
|
||
| Create this table in your database: | ||
|
|
||
| ``` | ||
| create table readings ( | ||
| device varchar(100), | ||
| measurement varchar(60), | ||
| value float, | ||
| tstamp int, | ||
| description varchar(100), | ||
| unit varchar(10), | ||
| primary key (device, measurement, tstamp), | ||
| index idx_tstamp (tstamp) | ||
| ) | ||
| ``` | ||
|
|
||
| ### MySQL parameters | ||
|
|
||
| Run mbmd with: | ||
|
|
||
| ``` | ||
| mbmd run -a ... -d ... --mysql-host={your-db-host:3306} --mysql-user={your-mysql-user} --mysql-password={mysql-user-password} --mysql-database={mysql-database-name} | ||
| ``` | ||
|
|
||
| for example: | ||
|
|
||
| ``` | ||
| mbmd run -a192.168.1.123:1502 -dSOLAREDGE:1.0 -dSOLAREDGE:1.1 -r2s --mysql-database=solaredge --mysql-host=127.0.0.1:3306 --mysql-user=mbmd --mysql-password=secret | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| package server | ||
|
|
||
| import ( | ||
| "database/sql" | ||
| "fmt" | ||
| "strings" | ||
| "sync" | ||
| "time" | ||
|
|
||
| _ "github.com/go-sql-driver/mysql" | ||
| ) | ||
|
|
||
| // MySQL publisher | ||
| type MySQL struct { | ||
| client *sql.DB | ||
| } | ||
|
|
||
| // NewMySQLClient creates new publisher for MySQL | ||
| func NewMySQLClient( | ||
| host string, | ||
| user string, | ||
| password string, | ||
| database string, | ||
| ) *MySQL { | ||
| connString := user + ":" + password + "@tcp(" + host + ")/" + database | ||
| db, err := sql.Open("mysql", connString) | ||
| if err != nil { | ||
| panic(err.Error()) | ||
|
There was a problem hiding this comment. IMHO: Please no panic, return an error with proper information |
||
| } | ||
|
|
||
| err = db.Ping() | ||
| if err != nil { | ||
| panic(err.Error()) | ||
| } | ||
|
|
||
| return &MySQL{ | ||
| client: db, | ||
| } | ||
| } | ||
|
|
||
| // Run MySQL publisher | ||
| func (m *MySQL) Run(in <-chan QuerySnip) { | ||
|
|
||
| var items []string | ||
| var vals []interface{} | ||
| var sql string | ||
| var mu sync.Mutex | ||
|
|
||
| ticker := time.NewTicker(time.Second) | ||
|
|
||
| for { | ||
| select { | ||
| case snip, ok := <-in: | ||
| if !ok { | ||
| return | ||
| } | ||
|
|
||
| description, unit := snip.Measurement.DescriptionAndUnit() | ||
|
|
||
| mu.Lock() | ||
| items = append(items, "(?, ?, ?, ?, ?, ?)") | ||
| vals = append(vals, snip.Device, snip.Measurement.String(), snip.Value, snip.Timestamp.Unix(), description, unit) | ||
| mu.Unlock() | ||
|
|
||
| case <-ticker.C: | ||
| if len(items) == 0 { | ||
| fmt.Println("Nothing to do ...", time.Now().Unix()) | ||
|
There was a problem hiding this comment. IMHO: this will pollute the output with no valueable informatin. Remove it. |
||
| continue | ||
| } | ||
|
|
||
| mu.Lock() | ||
|
|
||
| sql = "INSERT INTO readings (device, measurement, value, tstamp, description, unit) " + | ||
| " VALUES " + strings.Join(items, ",") | ||
|
|
||
| stmt, err := m.client.Prepare(sql) | ||
| if err != nil { | ||
| fmt.Println("Error preparing statement:", err) | ||
|
There was a problem hiding this comment. IMHO: Please use |
||
| mu.Unlock() | ||
| continue | ||
| } | ||
| if _, err := stmt.Exec(vals...); err != nil { | ||
| fmt.Println("Error executing statement:", err) | ||
| } | ||
|
|
||
| fmt.Println("Added: ", time.Now().Unix(), len(items)) | ||
|
|
||
| items = nil | ||
|
|
||
| vals = nil | ||
|
|
||
| mu.Unlock() | ||
|
|
||
| stmt.Close() | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO: What if I want to connect to pgsql or sqlite or mssql? At least provide an adapter/interface where other developers can integrate their desired DB. Also the CLI args should be then:
db.type=mysql,db.host,db.userand so on