fix: env-vars for application.yaml

volo-db · May 16, 2024 · 1ea39c4 · 1ea39c4
1 parent 3309a9f
commit 1ea39c4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/.github/workflows/dockerprod-deploy.yml b/.github/workflows/dockerprod-deploy.yml
@@ -33,6 +33,12 @@ jobs:
 
       - name: Build with Maven
         run: mvn -B package --file pom.xml
+        env:
+          MINIO_PORT: ${{ secrets.MINIO_PORT }}
+          MINIO_ACCESS_KEY: ${{ secrets.MINIO_ACCESS_KEY }}
+          MINIO_SECRET_KEY: ${{ secrets.MINIO_SECRET_KEY }}
+          MYSQL_ROOT_PASSWORD: ${{ secrets.MYSQL_ROOT_PASSWORD }}
+          JWT_SECRETKEY: ${{ secrets.JWT_SECRETKEY }}
 
       - name: Deploy via Docker
         run: |

diff --git a/src/main/resources/application.yaml b/src/main/resources/application.yaml
@@ -4,9 +4,9 @@ application:
 
 volodb:
   minio:
-    url: http://minio:9000
-    access-key: hnvDi0J0TkJzIveMpUx7
-    secret-key: GKgCXqOE7Y7E9TpeT3BCdrfFEHNhrQrXdVyHJNZu
+    url: http://minio:${MINIO_PORT}
+    access-key: ${MINIO_ACCESS_KEY}
+    secret-key: ${MINIO_SECRET_KEY}
 
 spring:
   application:
@@ -18,7 +18,7 @@ spring:
   datasource:
     url: "jdbc:mysql://mysql:3306/volo_db"
     username: root
-    password: test1234
+    password: ${MYSQL_ROOT_PASSWORD}
   servlet:
     multipart:
       max-file-size: -1
@@ -41,7 +41,7 @@ springdoc:
 
 security:
   jwt:
-    secret-key: "37fe5eb93cfbf3b1189cce4baf73f0c3bf882dc9b9f2ea8006546801e0b6a66a"
+    secret-key: ${JWT_SECRETKEY}
     token-duration: 12H
 
 logging: