Open
Conversation
yurii-litvinov
approved these changes
Oct 29, 2020
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
В целом всё правильно, зачтена
| | Application (left, right) -> isFree left variable || isFree right variable | ||
|
|
||
| /// Замена переменной в выражении | ||
| let rec substitution oldVariable newVariable expression = |
There was a problem hiding this comment.
newVariable --- не лучшее название для подставляемого вместо переменной терма. Может показаться, что он может быть только переменной
| |> betaReduction | ||
| |> should equal (Application(Variable('x'), Variable('y'))) | ||
|
|
||
| // (λx.x y) |
There was a problem hiding this comment.
Вообще, выражение за лямбдой --- это термы справа до скобки, так что тут имелось в виду (λx.x) y. В тестах ниже тоже. Это запутывает
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.