Skip to content

Conversation

@kluge7
Copy link
Contributor

@kluge7 kluge7 commented Mar 27, 2025

Mainly just formatting, fixing codecov and adding CI workflows

@kluge7 kluge7 self-assigned this Mar 27, 2025
@kluge7 kluge7 requested a review from Copilot March 27, 2025 21:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up various continuous integration workflows and refines documentation and code formatting configurations. Key changes include:

  • Correction of typos in documentation.
  • Addition and adjustment of CI configuration files (.github/workflows, codecov.yml, ruff.toml, .pre-commit-config.yaml).
  • Major update to the clang-format configuration adopting the Chromium-based style.

Reviewed Changes

Copilot reviewed 62 out of 71 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vortex-filtering/include/vortex_filtering/filters/README.md Fixed typo in documentation comment.
vortex-filtering/README.md Corrected method signature comments with spelling improvements.
ruff.toml Added linting configuration.
codecov.yml Updated path quoting in coverage configuration.
README.md Minor cleanup in project README.
.pre-commit-config.yaml Added pre-commit hooks configuration for consistent code quality.
.github/workflows/semantic-release.yml Added workflow for semantic releases.
.github/workflows/industrial-ci.yml Added industrial CI workflow.
.github/workflows/code-coverage.yml Added workflow for code coverage reporting.
.clang-format Major update of coding style and formatting configuration to align with Chromium style.
Files not reviewed (9)
  • .github/workflows/clang-formatter.yml: Language not supported
  • .github/workflows/run-unit-tests.yml: Language not supported
  • scripts/ci_install_dependencies.sh: Language not supported
  • vortex-filtering/include/vortex_filtering/filters/ekf.hpp: Language not supported
  • vortex-filtering/include/vortex_filtering/filters/imm_filter.hpp: Language not supported
  • vortex-filtering/include/vortex_filtering/filters/immipda.hpp: Language not supported
  • vortex-filtering/include/vortex_filtering/filters/ipda.hpp: Language not supported
  • vortex-filtering/include/vortex_filtering/filters/pdaf.hpp: Language not supported
  • vortex-filtering/include/vortex_filtering/filters/ukf.hpp: Language not supported
Comments suppressed due to low confidence (1)

vortex-filtering/README.md:59

  • The word 'vurtual' appears to be a typo; it should be corrected to 'virtual'.
          +vurtual G_d() Mat_xv

@kluge7 kluge7 force-pushed the ci/setup-workflows branch from c2c4d48 to 6f00c84 Compare March 29, 2025 08:46
@codecov
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 84.00454% with 282 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (951dd8c) to head (bfd9861).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
vortex-filtering/test/probability_test.cpp 69.76% 0 Missing and 39 partials ⚠️
...ng/include/vortex_filtering/filters/imm_filter.hpp 69.91% 6 Missing and 28 partials ⚠️
vortex-filtering/test/state_test.cpp 61.19% 0 Missing and 26 partials ⚠️
vortex-filtering/test/imm_test.cpp 84.71% 0 Missing and 24 partials ⚠️
vortex-filtering/test/pdaf_test.cpp 84.76% 0 Missing and 23 partials ⚠️
vortex-filtering/test/ellipsoid_test.cpp 73.46% 0 Missing and 13 partials ⚠️
...ring/include/vortex_filtering/models/imm_model.hpp 77.08% 4 Missing and 7 partials ⚠️
...ex_filtering/numerical_integration/erk_methods.hpp 84.12% 5 Missing and 5 partials ⚠️
...e/vortex_filtering/probability/multi_var_gauss.hpp 78.72% 4 Missing and 6 partials ⚠️
vortex-filtering/src/utils/ellipse.cpp 75.67% 8 Missing and 1 partial ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   31.36%   84.75%   +53.38%     
===========================================
  Files          24       37       +13     
  Lines         880     1882     +1002     
  Branches      617     1212      +595     
===========================================
+ Hits          276     1595     +1319     
- Misses         31       57       +26     
+ Partials      573      230      -343     
Flag Coverage Δ
unittests 84.75% <84.00%> (+53.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...filtering/include/vortex_filtering/filters/ekf.hpp 100.00% <100.00%> (+85.00%) ⬆️
...filtering/include/vortex_filtering/filters/ukf.hpp 100.00% <100.00%> (+72.13%) ⬆️
...include/vortex_filtering/models/dynamic_models.hpp 100.00% <100.00%> (+64.70%) ⬆️
...tering/include/vortex_filtering/utils/plotting.hpp 100.00% <100.00%> (+70.00%) ⬆️
vortex-filtering/test/gtest_main.cpp 100.00% <100.00%> (ø)
vortex-filtering/test/test_models.hpp 100.00% <100.00%> (+50.00%) ⬆️
.../include/vortex_filtering/models/sensor_models.hpp 85.71% <85.71%> (+60.71%) ⬆️
...g/include/vortex_filtering/probability/uniform.hpp 90.90% <90.90%> (ø)
...tering/include/vortex_filtering/utils/printers.hpp 90.90% <90.90%> (ø)
vortex-filtering/test/ipda_test.cpp 95.45% <95.23%> (ø)
... and 27 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kluge7 kluge7 requested review from VegraD and jorgenfj March 29, 2025 08:58
@kluge7 kluge7 linked an issue Mar 29, 2025 that may be closed by this pull request
3 tasks
Copy link
Contributor

@jorgenfj jorgenfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kluge7 kluge7 merged commit 832736f into main Mar 29, 2025
5 checks passed
@kluge7 kluge7 deleted the ci/setup-workflows branch March 29, 2025 09:30
@kluge7 kluge7 restored the ci/setup-workflows branch March 29, 2025 09:30
kluge7 added a commit that referenced this pull request Mar 29, 2025
@kluge7 kluge7 deleted the ci/setup-workflows branch March 29, 2025 09:31
@kluge7 kluge7 restored the ci/setup-workflows branch March 29, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Add gcc compiler version

3 participants