Skip to content

Commit

Permalink
Don't announce subscriber_metaevents feature. It breaks crossbar and …
Browse files Browse the repository at this point in the history
…It's not fully supported anyway.
  • Loading branch information
davidwdan committed Mar 3, 2015
1 parent 687c4a5 commit 912671b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 20 deletions.
31 changes: 12 additions & 19 deletions src/Thruway/RealmManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,16 @@ class RealmManager
*/
public function __construct(ManagerInterface $manager = null)
{
$this->realms = [];
$this->realms = [];
$this->manager = $manager ?: new ManagerDummy();
$this->allowRealmAutocreate = true;
$this->defaultAuthorizationManager = new AllPermissiveAuthorizationManager();

$this->setAllowRealmAutocreate(true);
$this->setDefaultAuthenticationManager(null);

if ($manager === null) {
$manager = new ManagerDummy();
}

$this->manager = $manager;

$this->setDefaultAuthorizationManager(new AllPermissiveAuthorizationManager());
}

/**
* Get Realm bu realm name
*
* Get Realm by realm name
*
* @param string $realmName
* @throws \Thruway\Exception\InvalidRealmNameException
* @throws \Thruway\Exception\RealmNotFoundException
Expand All @@ -94,7 +87,7 @@ public function getRealm($realmName)

/**
* Add new realm
*
*
* @param \Thruway\Realm $realm
* @throws \Thruway\Exception\InvalidRealmNameException
* @throws \Exception
Expand Down Expand Up @@ -146,7 +139,7 @@ public static function validRealmName($name)

/**
* Get list realms
*
*
* @return array
*/
public function getRealms()
Expand All @@ -156,7 +149,7 @@ public function getRealms()

/**
* Set option allow auto create realm if not exist
*
*
* @param boolean $allowRealmAutocreate
*/
public function setAllowRealmAutocreate($allowRealmAutocreate)
Expand All @@ -166,7 +159,7 @@ public function setAllowRealmAutocreate($allowRealmAutocreate)

/**
* Get option allow auto create realm
*
*
* @return boolean
*/
public function getAllowRealmAutocreate()
Expand All @@ -176,7 +169,7 @@ public function getAllowRealmAutocreate()

/**
* Set default authentication manager
*
*
* @param \Thruway\Authentication\AuthenticationManagerInterface $defaultAuthenticationManager
*/
public function setDefaultAuthenticationManager($defaultAuthenticationManager)
Expand All @@ -186,7 +179,7 @@ public function setDefaultAuthenticationManager($defaultAuthenticationManager)

/**
* Get default authentication manager
*
*
* @return \Thruway\Authentication\AuthenticationManagerInterface
*/
public function getDefaultAuthenticationManager()
Expand Down
2 changes: 1 addition & 1 deletion src/Thruway/Role/Subscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function __construct()
public function getFeatures() {
$features = new \stdClass();

$features->subscriber_metaevents = true;
// $features->subscriber_metaevents = true;

return $features;
}
Expand Down

0 comments on commit 912671b

Please sign in to comment.