Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGORA-1849] Formal OAS for Agora API (delegates, auth, pagination) #212

Merged
merged 23 commits into from
Apr 12, 2024

Conversation

Flip-Liquid
Copy link
Contributor

@Flip-Liquid Flip-Liquid commented Apr 1, 2024

PR-Codex overview

This PR focuses on adding a Swagger Editor Validator Remote workflow to validate an OpenAPI definition file.

Detailed summary

  • Added a workflow for Swagger Editor validation
  • Defined OpenAPI specifications in spec/oas_v1.yaml
  • Included components like Delegation, BaseDelegate, Proposal, etc.
  • Described metadata and data structures for governance proposals

The following files were skipped due to too many changes: spec/oas_v1.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

You can use the following in-browser OAS editor and validator to get a prettier view of the API if you'd like:

https://editor-next.swagger.io/

Just copy-paste oas_v1.yaml into it.

Copy link

linear bot commented Apr 1, 2024

Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agora-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 9:22pm
agora-next-ens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 9:22pm
agora-next-etherfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 9:22pm

@Flip-Liquid
Copy link
Contributor Author

@kent @andreitr @stepandel, how do you feel about having discussion and feedback on the proposed schema on this PR?

@stepandel
Copy link
Contributor

@kent @andreitr @stepandel, how do you feel about having discussion and feedback on the proposed schema on this PR?

should we just follow this spec @Flip-Liquid ? https://www.notion.so/argoagora/Agora-s-OP-API-Draft-Document-32b2bed3193841d4b272b5ab39167cbb

Copy link
Contributor

@stepandel stepandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Flip-Liquid Flip-Liquid merged commit 9c7eca3 into main Apr 12, 2024
6 checks passed
@Flip-Liquid Flip-Liquid deleted the flip/openapi_spec branch April 12, 2024 23:59
kent pushed a commit that referenced this pull request Aug 30, 2024
…212)

* 💻📐 openapi swagger wip specification for /delegates
* 🤏 📃 🆚 bump version 3.1.0; add license; qualify beta
* 🏷️ rename to oas_v1.yaml
* 🔂 add CI/GHA file; integrate basic swagger linting
* 💻📐 add page metadata to OAS
* 📐 💻 add reusable datatypes for proposal, vote, delegation; routes for props
* 💫💻📐 add opt, approval, std, snapshot prop data; propType->votingStrategy; remove extended proposal
* 💻 /spec route for OAS
* 💻📐 add routes + contract schema
jefag pushed a commit that referenced this pull request Oct 4, 2024
…212)

* 💻📐 openapi swagger wip specification for /delegates
* 🤏 📃 🆚 bump version 3.1.0; add license; qualify beta
* 🏷️ rename to oas_v1.yaml
* 🔂 add CI/GHA file; integrate basic swagger linting
* 💻📐 add page metadata to OAS
* 📐 💻 add reusable datatypes for proposal, vote, delegation; routes for props
* 💫💻📐 add opt, approval, std, snapshot prop data; propType->votingStrategy; remove extended proposal
* 💻 /spec route for OAS
* 💻📐 add routes + contract schema
jefag pushed a commit that referenced this pull request Oct 4, 2024
…212)

* 💻📐 openapi swagger wip specification for /delegates
* 🤏 📃 🆚 bump version 3.1.0; add license; qualify beta
* 🏷️ rename to oas_v1.yaml
* 🔂 add CI/GHA file; integrate basic swagger linting
* 💻📐 add page metadata to OAS
* 📐 💻 add reusable datatypes for proposal, vote, delegation; routes for props
* 💫💻📐 add opt, approval, std, snapshot prop data; propType->votingStrategy; remove extended proposal
* 💻 /spec route for OAS
* 💻📐 add routes + contract schema
jefag pushed a commit that referenced this pull request Oct 8, 2024
…212)

* 💻📐 openapi swagger wip specification for /delegates
* 🤏 📃 🆚 bump version 3.1.0; add license; qualify beta
* 🏷️ rename to oas_v1.yaml
* 🔂 add CI/GHA file; integrate basic swagger linting
* 💻📐 add page metadata to OAS
* 📐 💻 add reusable datatypes for proposal, vote, delegation; routes for props
* 💫💻📐 add opt, approval, std, snapshot prop data; propType->votingStrategy; remove extended proposal
* 💻 /spec route for OAS
* 💻📐 add routes + contract schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants