Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft proposals v2 #606

Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open

Draft proposals v2 #606

wants to merge 61 commits into from

Conversation

mcgingras
Copy link
Collaborator

@mcgingras mcgingras commented Nov 13, 2024

Description

For context, check this notion doc.

TODO

Issues

@CarlGocht @pedrohasf whoever is left to adopt my baby after I leave, here's a list of everything I'm aware of that I've not gotten a chance to fix.

  • Clicking "visibility' label on the final step of the form seems to navigate you back a step?
  • Not every time, but sometimes, clicking submit on the final step does not submit the form. It does.... nothing? A second click solves the problem, but it's bad UX.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agora-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 9:29pm
agora-next-boost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 9:29pm
agora-next-cyber ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 9:29pm
agora-next-demo ❌ Failed (Inspect) Feb 5, 2025 9:29pm
agora-next-derive ❌ Failed (Inspect) Feb 5, 2025 9:29pm
agora-next-ens ❌ Failed (Inspect) Feb 5, 2025 9:29pm
agora-next-etherfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 9:29pm
agora-next-optimism ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 9:29pm
agora-next-pguild ❌ Failed (Inspect) Feb 5, 2025 9:29pm
agora-next-scroll ❌ Failed (Inspect) Feb 5, 2025 9:29pm
agora-next-uniswap ❌ Failed (Inspect) Feb 5, 2025 9:29pm
agora-next-xai ❌ Failed (Inspect) Feb 5, 2025 9:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
agora-next-dao ⬜️ Ignored (Inspect) Feb 5, 2025 9:29pm

@mcgingras
Copy link
Collaborator Author

mcgingras commented Feb 26, 2025

@jefag @CarlGocht @pedrohasf @sudheerDev

I rebased these changes off of main locally. I thought it might be helpful for me to keep this branch rebased periodically but I want to make sure it's okay with you guys before I push up changes. Honestly, I'm not even sure if I have write access anymore, but before I tested that out I wanted to run it by y'all before you got a mystery rebase to this branch.

Cheers y'all, let me know.

@jefag
Copy link
Contributor

jefag commented Feb 27, 2025

Hey @mcgingras , that's generous of you. Thank you for thinking of us and helping.

I think taking an open-source approach from here makes sense. With that as our guide, you can safely assume you own this branch, until its merged. Somebody internally is going to pick this up, but until they push what they have. Whatever they are or aren't doing on their local, is their problem until they socialize.

A rebase would be helpful.

tl;dr feel free to force-push!

PS - I believe you still have rights to "write" this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants