ENG-1138 Add delegate statement html sanitization #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
JIRA Issue: ENG-1138 |
pedrohasf
approved these changes
Feb 11, 2025
sudheerDev
approved these changes
Feb 12, 2025
Signed-off-by: CarlGocht <3064220+CarlGocht@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does both client and server side sanitization and leaves urls available for use
Tested against ENS thoroughly using the given eval statement. Also tested on uniswap the same way.
Tested on ENS using the markdown that we are meant to support from another users delegate statement to make sure this does not interfere with markdown. That user is here https://agora-next-kjr7yzj80-voteagora.vercel.app/delegates/0x0fcd2ead9943194eaa8bc6702a97555aad50455b