Fix resolve safe transaction receipt for voting #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
JIRA Issue: ENG-1183 |
sudheerDev
reviewed
Feb 28, 2025
| }; | ||
|
|
||
| export const wrappedWaitForTransactionReceipt = async ( | ||
| publicClient: PublicClient, |
There was a problem hiding this comment.
Is there a reason why pass in client here? Since the plan is to move to use this function mostly, should we move the client to be called in this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation hopefully should replace all instances of waitForTransactionReceipt in the long term. Keeping it contained to voting right now as it would impact critical functions of the app and needs to be thoroughly tested