-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mongo): Bump min mongo version to 5.0 #5476
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the MongoDB version requirement by changing the constant MIN_MONGODB_VERSION in the code. The constant is now set to Version("5.0") instead of Version("4.4"), reflecting the need for MongoDB version 5.0 or higher for proper functionality. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🔇 Additional comments (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like @benjaminpkane to chime in here, but this seems good to me...
What changes are proposed in this pull request?
Rceently, we added support for automatic fcv migrations. Now, we can update the minimum mongoDB version.
How is this patch tested? If it is not, please explain why.
Tested against a mongoDB 4.4 container and validated errors.
Tested against a mongoDB 5.0.4 container and validated no errors.
Tested against the embedded mongoDB and validated no errors.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
FiftyOne has officially deprecated MongoDB 4.4. If you're using a self-hosted mongoDB instance, please ensure it is on 5.0+. If you're using the embedded MongoDB instance, please upgrade FiftyOne.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit