Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mongo): Bump min mongo version to 5.0 #5476

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

afoley587
Copy link
Member

@afoley587 afoley587 commented Feb 7, 2025

What changes are proposed in this pull request?

Rceently, we added support for automatic fcv migrations. Now, we can update the minimum mongoDB version.

How is this patch tested? If it is not, please explain why.

Tested against a mongoDB 4.4 container and validated errors.

RuntimeError: Found `mongod` version 4.4.29, but only 5.0 and higher are compatible. You can suppress this exception by setting your `database_validation` config parameter to `False`. See https://docs.voxel51.com/user_guide/config.html#configuring-a-mongodb-connection for more information

Tested against a mongoDB 5.0.4 container and validated no errors.
Tested against the embedded mongoDB and validated no errors.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

FiftyOne has officially deprecated MongoDB 4.4. If you're using a self-hosted mongoDB instance, please ensure it is on 5.0+. If you're using the embedded MongoDB instance, please upgrade FiftyOne.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • Chores
    • Updated the application’s minimum MongoDB requirement from 4.4 to 5.0, ensuring enhanced performance and compatibility. Please verify that your environment meets this new requirement.

Copy link
Contributor

coderabbitai bot commented Feb 7, 2025

Walkthrough

This pull request updates the MongoDB version requirement by changing the constant MIN_MONGODB_VERSION in the code. The constant is now set to Version("5.0") instead of Version("4.4"), reflecting the need for MongoDB version 5.0 or higher for proper functionality.

Changes

File(s) Change Summary
fiftyone/constants.py Updated constant MIN_MONGODB_VERSION from Version("4.4") to Version("5.0")

Possibly related PRs

Suggested labels

release

Suggested reviewers

  • findtopher
  • benjaminpkane

Poem

I'm a rabbit, hopping with glee,
A tiny change made just for me.
MongoDB leaps to version five,
In code I dance, I feel alive.
With whiskers twitching, let's all celebrate! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f35a740 and 17bca0c.

📒 Files selected for processing (1)
  • fiftyone/constants.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: test / test-python (ubuntu-latest-m, 3.10)
  • GitHub Check: test / test-app
  • GitHub Check: lint / eslint
  • GitHub Check: e2e / test-e2e
  • GitHub Check: build / build
  • GitHub Check: build
🔇 Additional comments (1)
fiftyone/constants.py (1)

104-104: LGTM! Version update aligns with testing results.

The change from 4.4 to 5.0 is well-tested and supports the new automatic feature compatibility version migrations.

Please ensure the following documentation updates are made:

  1. Update release notes to clearly communicate this breaking change
  2. Add migration guide for users on MongoDB 4.4
  3. Document the database_validation configuration parameter for suppressing version checks

Let's verify the version compatibility with related constants:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Check if the new minimum version is compatible with other MongoDB version constants

# Search for any other MongoDB version constants that might need updates
rg -n "Version\([\"'][\d\.]+[\"']\)" --type py

# Look for any MongoDB version checks in the codebase
rg -n "mongodb.*version" -A 3 --type py

Length of output: 1872


MongoDB version compatibility verified and documentation update recommended

The MIN_MONGODB_VERSION update is aligned with the other version constants and test expectations. The tests in tests/unittests/fcv_tests.py confirm the intended migration behavior. Please ensure that accompanying documentation (release notes, migration guide, and settings descriptions) is updated accordingly.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@afoley587 afoley587 requested a review from findtopher February 7, 2025 18:38
Copy link
Member

@findtopher findtopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like @benjaminpkane to chime in here, but this seems good to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants