Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh restart for Ubuntu #1885

Merged
merged 1 commit into from
May 24, 2024
Merged

Add ssh restart for Ubuntu #1885

merged 1 commit into from
May 24, 2024

Conversation

skyamgarp
Copy link
Contributor

@skyamgarp skyamgarp commented May 20, 2024

Changes for Ubuntu 24.04

This is to resolve error:
systemctl restart sshd.service Last 10 lines of output were: Failed to restart sshd.service: Unit sshd.service not found.>

@skyamgarp skyamgarp marked this pull request as draft May 20, 2024 06:58
@skyamgarp skyamgarp marked this pull request as ready for review May 20, 2024 16:36
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocking issue but it would be great to future proof beaker, so make "systemctl ssh" the default for all future Ubuntu, Debian, ??? versions. That way we won't need to update beaker for each new platform addition.

@skyamgarp
Copy link
Contributor Author

skyamgarp commented May 21, 2024

Not a blocking issue but it would be great to future proof beaker, so make "systemctl ssh" the default for all future Ubuntu, Debian, ??? versions. That way we won't need to update beaker for each new platform addition.

Earlier it was:
when /debian|ubuntu/ exec(Beaker::Command.new("service ssh restart"))

Can we just go back to this instead of doing it for versions specifically?

@skyamgarp skyamgarp force-pushed the PA-6032 branch 2 times, most recently from 450da25 to 03ee3da Compare May 21, 2024 18:33
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this regression.

Edit: please drop the PA-6032 from the commit. This isn't a Puppetlabs project.

lib/beaker/host/unix/exec.rb Outdated Show resolved Hide resolved
@ekohl ekohl added the bug label May 21, 2024
@skyamgarp skyamgarp force-pushed the PA-6032 branch 2 times, most recently from fc0e0cc to 4d172f3 Compare May 23, 2024 14:07
spec/helpers.rb Outdated
@@ -129,5 +129,5 @@ module PlatformHelpers
redhat
oracle
scientific
archlinux].concat(DEBIANPLATFORMS)
archlinux]
Copy link
Contributor

@joshcooper joshcooper May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove DEBIANPLATFORMS? Oh I see. Maybe rename SYSTEMDPLATFORMS to RHELPLATFORMS?

@skyamgarp skyamgarp changed the title (PA-6032) Add ssh restart for Ubuntu Add ssh restart for Ubuntu May 23, 2024
@skyamgarp skyamgarp force-pushed the PA-6032 branch 2 times, most recently from a7848ad to ca73942 Compare May 24, 2024 11:09
@skyamgarp skyamgarp requested a review from ekohl May 24, 2024 11:20
@skyamgarp skyamgarp force-pushed the PA-6032 branch 2 times, most recently from 8db418c to 1c686d2 Compare May 24, 2024 11:44
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small naming nit, otherwise 👍

spec/helpers.rb Outdated Show resolved Hide resolved
Fix Rubocop

Fixed failing test

Update RHELPLATFORMS

Fix Robocop

Fixed platforms name to REDHATPLATFORMS
@skyamgarp
Copy link
Contributor Author

Can we please merge this PR? @joshcooper , @bastelfreak , @ekohl

@mhashizume mhashizume requested a review from ekohl May 24, 2024 17:15
@joshcooper
Copy link
Contributor

Can we please merge this PR?

Yes I think all concerns have been resolved since @ekohl gave 👍 and you updated to REDHAT_PLATFORMS.

@joshcooper joshcooper merged commit 463a897 into voxpupuli:master May 24, 2024
7 checks passed
@skyamgarp skyamgarp deleted the PA-6032 branch May 27, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants