-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssh restart for Ubuntu #1885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocking issue but it would be great to future proof beaker, so make "systemctl ssh" the default for all future Ubuntu, Debian, ??? versions. That way we won't need to update beaker for each new platform addition.
Earlier it was: Can we just go back to this instead of doing it for versions specifically? |
450da25
to
03ee3da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this regression.
Edit: please drop the PA-6032
from the commit. This isn't a Puppetlabs project.
fc0e0cc
to
4d172f3
Compare
spec/helpers.rb
Outdated
@@ -129,5 +129,5 @@ module PlatformHelpers | |||
redhat | |||
oracle | |||
scientific | |||
archlinux].concat(DEBIANPLATFORMS) | |||
archlinux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove Oh I see. Maybe rename DEBIANPLATFORMS
?SYSTEMDPLATFORMS
to RHELPLATFORMS
?
a7848ad
to
ca73942
Compare
8db418c
to
1c686d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small naming nit, otherwise 👍
Fix Rubocop Fixed failing test Update RHELPLATFORMS Fix Robocop Fixed platforms name to REDHATPLATFORMS
Can we please merge this PR? @joshcooper , @bastelfreak , @ekohl |
Yes I think all concerns have been resolved since @ekohl gave 👍 and you updated to |
Changes for Ubuntu 24.04
This is to resolve error:
systemctl restart sshd.service Last 10 lines of output were: Failed to restart sshd.service: Unit sshd.service not found.>