beaker: Make vagrant installation optional #63
Conversation
When we run beaker jobs for vagrant_libvirt on dedicated servers, we control the host. That means we can already install the apt repo + packages. We even have to do it because when multiple beaker jobs start and they want to call `apt` in parallel, it fails.
|
This is a requirement for us to run beaker jobs on self-hosted / persistent runners. |
| @@ -176,6 +181,7 @@ jobs: | |||
| bundler-cache: true | |||
| cache-version: ${{ inputs.cache-version }} | |||
| working-directory: ${{ inputs.working-directory }} | |||
| self-hosted: ${{ inputs.acceptance_runs_on != 'ubuntu-24.04' }} | |||
There was a problem hiding this comment.
my other idea was to match on the name of self-hosted runner, instead of a negative match on the github runners. But we already have two different self-hosted runner groups and maybe more in the future, so the negative match is easier.
There was a problem hiding this comment.
Shouldn't the auto-detection in https://github.com/ruby/setup-ruby/blob/a6e6f86333f0a2523ece813039b8b4be04560854/common.js#L165-L176 work for that already?
There was a problem hiding this comment.
one would think! Basically: If the OS of the self-hosted runner doesn't look like the OS GitHub uses, auto-detection works. The CERN-provided runners are on EL9, so that works. Now this time I wanted to be smart and thought 'it is easier to configure the runner software if my OS is the same as GitHub uses', so our new runners are... Ubuntu 24.04. And that breaks auto-detection :sadface:
There was a problem hiding this comment.
my problem with this is that if anyone decides to set acc_runs_on to anything but 24.04, it will trigger, even if it's not really a self-hosted runner.
There was a problem hiding this comment.
| self-hosted: ${{ inputs.acceptance_runs_on != 'ubuntu-24.04' }} | |
| self-hosted: ${{ ! startsWith(inputs.acceptance_runs_on, 'ubuntu-') }} |
There was a problem hiding this comment.
will test it and provide a PR if it works
When we run beaker jobs for vagrant_libvirt on dedicated servers, we control the host. That means we can already install the apt repo + packages. We even have to do it because when multiple beaker jobs start and they want to call
aptin parallel, it fails.