Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] updated default version to Bareos 21 #103

Closed
wants to merge 1 commit into from

Conversation

hugendudel
Copy link
Contributor

Pull Request (PR) description

updated default version to Bareos 21

This Pull Request (PR) fixes the following issues

Fixes #80

@jhoblitt
Copy link
Member

jhoblitt commented Oct 6, 2022

@hugendudel thank you for the contribution. The gha status seems to be stuck and I'm not a repo admin to override it. I've rebased this branch on the current master as #115 and merged it.

@jhoblitt
Copy link
Member

jhoblitt commented Nov 3, 2022

@hugendudel Are you using this mod to manage baseos 21? It looks like [without] the removal of the bareos-database-mysql package would cause it to fail.

@hugendudel
Copy link
Contributor Author

We use it with PostgreSQL, I will have a look at this issue tomorrow(UTC+1).

@hugendudel
Copy link
Contributor Author

Ok, MySQL seems to be no longer supported. This information should be published somehow.
https://www.bareos.com/end-of-life-mysql/
And of course also remove the legacy.

@hugendudel
Copy link
Contributor Author

MR is probably needed here, should we open an issue?

@jhoblitt
Copy link
Member

jhoblitt commented Nov 3, 2022

@hugendudel I've put a kludge on the acceptance branch to remove the sqlite3/mysql packages. E.g. 68ddca3

However, as a real "fix" I would like to delete the db_driver class parameter completely as the docs say this config file value is deprecated as well. I would prefer not to have to support sqlite3/mysql for baseos < 21. The question is is anyone is using this modules with sqlite3/mysql and bareos 19.2 or 20?

@hugendudel
Copy link
Contributor Author

There's always someone using it, isn't it? But imho, one should read the release notes before updating?

@hugendudel
Copy link
Contributor Author

Ok a suggestion, I'm not sure if a new version has been released since the change. But we could now build a release indicating this, and reset the default value for now?

@jhoblitt
Copy link
Member

jhoblitt commented Nov 3, 2022

I had planned to make a 2.0.0 release of this mod (#121) but that was before I was aware of the baseos 21 compatibility issues. We really need to get #109 sorted out. I've opened #125 as a live issue for this discussion. Can we shift this thread to the new issue?

@hugendudel
Copy link
Contributor Author

Can we shift this thread to the new issue?
please! and feel free to revert the change if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo URL /latest/ is deprecated
3 participants