Fix falco-driver-loader bpf #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix legacy use of fact
hunner
force-pushed
the
fix-driver-loader-bpf
branch
from
f0571be
to
e5ce3f8
Compare
bastelfreak
reviewed
Jul 6, 2023
hunner
force-pushed
the
fix-driver-loader-bpf
branch
from
e5ce3f8
to
873bf2b
Compare
hunner
force-pushed
the
fix-driver-loader-bpf
branch
from
873bf2b
to
0730b38
Compare
bastelfreak
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Added another exec for when building the bpf probe. This is because the falco-driver-loader bpf command looks in the home folder of the user that runs falco(root) to see if theres already a probe existent. Therefore when running puppet and no home folder exists, it will put the driver in the wrong location.
This Pull Request (PR) fixes the following issues
Falco could not detect if a bpf probe was available, because upon running the falco-driver-loader command the bpf probe would be put in the wrong location.