Add parameters to apt::source to avoid requiring an internet connection
#100
Conversation
kenyon
changed the title
apt::source to avoid requiring an internet connexionapt::source to avoid requiring an internet connection
micedre
force-pushed
the
issue/fix-90
branch
from
cc1b82d
to
9e717f3
Compare
|
I added some tests by copying some existing, but I didn't manage to execute those (following what I see in .github/CONTRIBUTING.md). Do you have some pointer to execute those tests ? |
|
Dear @micedre, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Signed-off-by: Cédric Couralet <cedric.couralet@insee.fr>
|
I don't really understand what fails in this CI, it does not seem to come from my modification (but maybe), can you give some pointer on how to fix it? |
manifests/repo.pp
Outdated
| $package_name = $gitlab_ci_runner::package_name, | ||
| $repo_base_url = $gitlab_ci_runner::repo_base_url, | ||
| $repo_keyserver = $gitlab_ci_runner::repo_keyserver, | ||
| $repo_keyid = $gitlab_ci_runner::repo_keyid, |
There was a problem hiding this comment.
$repo_keyid is missing in manifests init.pp
There was a problem hiding this comment.
Thank you, I removed this parameter, as it was not used.
micedre
force-pushed
the
issue/fix-90
branch
2 times, most recently
from
153e206
to
ea8fd90
Compare
Signed-off-by: Cedric Couralet <cedric.couralet@insee.fr> Signed-off-by: Cédric Couralet <cedric.couralet@insee.fr>
| Optional[Gitlab_ci_runner::Log_level] $log_level = undef, | ||
| Optional[Gitlab_ci_runner::Log_format] $log_format = undef, |
| Optional[Gitlab_ci_runner::Log_level] $log_level = undef, | ||
| Optional[Gitlab_ci_runner::Log_format] $log_format = undef, | ||
| Optional[Integer] $check_interval = undef, | ||
| Optional[String] $sentry_dsn = undef, |
There was a problem hiding this comment.
GitHub fscked'up my in-line comment… I an speaking about $sentry_dsn.
| Optional[Integer] $check_interval = undef, | ||
| Optional[String] $sentry_dsn = undef, | ||
| Optional[Pattern[/.*:.+/]] $listen_address = undef, | ||
| Optional[Gitlab_ci_runner::Session_server] $session_server = undef, |
| Optional[Gitlab_ci_runner::Keyserver] $repo_keyserver = undef, | ||
| String $config_path = '/etc/gitlab-runner/config.toml', | ||
| String[1] $config_owner = 'root', | ||
| String[1] $config_group = 'root', | ||
| Stdlib::Filemode $config_mode = '0444', | ||
| Boolean $manage_config_dir = false, | ||
| Optional[Stdlib::Filemode] $config_dir_mode = undef, | ||
| Optional[Stdlib::HTTPUrl] $http_proxy = undef, | ||
| Optional[Stdlib::Unixpath] $ca_file = undef, | ||
| String $xz_package_name, # Defaults in module hieradata | ||
| Hash $runners = {}, | ||
| Hash $runner_defaults = {}, | ||
| Optional[Integer] $concurrent = undef, | ||
| Optional[Integer] $check_interval = undef, | ||
| Optional[String] $builds_dir = undef, | ||
| Optional[String] $cache_dir = undef, | ||
| Optional[Pattern[/.*:.+/]] $metrics_server = undef, | ||
| Optional[Pattern[/.*:.+/]] $listen_address = undef, | ||
| Optional[String] $sentry_dsn = undef, | ||
| Boolean $manage_docker = false, | ||
| Boolean $manage_repo = true, | ||
| String $package_ensure = installed, | ||
| String $package_name = 'gitlab-runner', | ||
| Stdlib::HTTPUrl $repo_base_url = 'https://packages.gitlab.com', | ||
| Optional[Stdlib::Fqdn] $repo_keyserver = undef, |
| Optional[String] $builds_dir = undef, | ||
| Optional[String] $cache_dir = undef, | ||
| Optional[Pattern[/.*:.+/]] $metrics_server = undef, |
There was a problem hiding this comment.
These changes seems unrelated to this PR.
Pull Request (PR) description
Adds some parameters to
apt::sourceon debian family when managing repo.This Pull Request (PR) fixes the following issues
Fixes #99