Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Puppet 8 support #173

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Add Puppet 8 support #173

merged 2 commits into from
Dec 4, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak added the enhancement New feature or request label Jul 2, 2023
@smortex
Copy link
Member

smortex commented Jul 3, 2023

I saw similar issues for the modules of @opus-codium, and a ModuleSync update helped.

#170 was about it but I got stuck by ENTREPRISE LINUX issues. A quick fix of dropping CentOS 7 is I guess not acceptable 🙃

@bastelfreak
Copy link
Member Author

I think CentOS 7 is so old and we've the option to support EL8 and EL9, I think it's fine to drop CentOS 7 if it helps moving forward.

@smortex smortex closed this Sep 26, 2023
@smortex smortex reopened this Sep 26, 2023
smortex
smortex reviewed Sep 26, 2023
View reviewed changes
spec/tasks/register_runner_spec.rb
and_return('id' => 777, 'token' => '3bz5wqfDiYBhxoUNuGVu')

expect(described_object.task(params)).to eq('id' => 777, 'token' => '3bz5wqfDiYBhxoUNuGVu')
expect(described_object.task(**params)).to eq('id' => 777, 'token' => '3bz5wqfDiYBhxoUNuGVu')
Copy link
Member

@smortex smortex Sep 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix

       wrong number of arguments (given 1, expected 0)

smortex
smortex reviewed Sep 26, 2023
View reviewed changes
spec/tasks/unregister_runner_spec.rb
@@ -15,17 +15,17 @@
describe '.task' do
it 'can unregister a runner' do
allow(PuppetX::Gitlab::Runner).to receive(:unregister).
with('https://gitlab.example.org', token: 'abcdef1234').
with('https://gitlab.example.org', { token: 'abcdef1234' }).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix:

       PuppetX::Gitlab::Runner received :unregister with unexpected arguments
         expected: ("https://gitlab.example.org", {:token=>"abcdef1234"}) (keyword arguments)
              got: ("https://gitlab.example.org", {:token=>"abcdef1234"}) (options hash)
        Please stub a default value first if message might be received with other args as well.

@smortex smortex force-pushed the puppet8_20230723 branch 3 times, most recently from 5b84a85 to 2d84376 Compare September 26, 2023 02:19
@smortex
Copy link
Member

smortex commented Sep 26, 2023 •
edited
Loading

Comparing Puppet 7 and 8, we have this error with Puppet 8:

2023-09-26T02:29:11.2843101Z �[00;00m�[00;33m Error: /Stage[main]/Gitlab_ci_runner::Config/Concat[/etc/gitlab-runner/config.toml]/Concat_file[/etc/gitlab-runner/config.toml]: Failed to generate additional resources using 'eval_generate': no implicit conversion of Puppet::Pops::Evaluator::DeferredValue into String

This led me to:
puppetlabs/puppetlabs-concat#789

@smortex
Copy link
Member

smortex commented Dec 2, 2023

Now that puppetlabs/puppetlabs-concat#789 is released in puppetlabs-concat 9.0.1, this will maybe pass with Puppet 8? Close and re-open to give it another try.

@smortex smortex closed this Dec 2, 2023
@smortex smortex reopened this Dec 2, 2023
smortex
smortex approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is happy now.

@bastelfreak bastelfreak merged commit 8f7675d into master Dec 4, 2023
53 of 68 checks passed
@bastelfreak bastelfreak deleted the puppet8_20230723 branch December 4, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @smortex