Master / Slave terminology change

[FunPat]

Pull Request (PR) description

Breaking change for existing instances.
This PR is designed to refactor the "master" and "slave" terminology used by the puppet-jenkins module to be more inclusive, more appropriate and as per the newer stance on this terminology by Jenkins. Replacing these terms with the Jenkins preferred "controller" and "agent" terminology as noted by Marky Jackson in 2020 - https://www.jenkins.io/blog/2020/06/18/terminology-update/

This is a fantastic module and it is a real shame it still uses this terminology (master / slave), whilst valid for describing the technical relationship between the components and has historically been used across a wide array of software and technology, it doesn't provide a great outcome for the people side of IT and development, and some individuals may be offended or feel strongly against this as it isn't a favorable term based on it's history. As a member of a progressive university, I believe it is my social responsibility to enact change where I am able to, a few of my colleagues also raised similar issues with the naming convention hence why I've spent the time to refactor the code.

The change is a significant change to the module from a naming perspective, however it should be possible to refactor the references in one's code base to then move / recreate the appropriate directory to use this new version. All internal Jenkins calls to ie sshslaves have been left in tact as changes cannot be made to these elements without breaking the module.

PS C:\devel\puppet-jenkins> bundle exec rake validate
ruby -c lib/facter/jenkins.rb
Syntax OK
ruby -c lib/puppet/jenkins/plugins.rb
Syntax OK
ruby -c lib/puppet/jenkins.rb
Syntax OK
ruby -c lib/puppet/parser/functions/jenkins_port.rb
Syntax OK
ruby -c lib/puppet/parser/functions/jenkins_prefix.rb
Syntax OK
ruby -c lib/puppet/provider/jenkins_agent_port/cli.rb
Syntax OK
ruby -c lib/puppet/provider/jenkins_authorization_strategy/cli.rb
Syntax OK
ruby -c lib/puppet/provider/jenkins_credentials/cli.rb
Syntax OK
ruby -c lib/puppet/provider/jenkins_job/cli.rb
Syntax OK
ruby -c lib/puppet/provider/jenkins_num_executors/cli.rb
Syntax OK
ruby -c lib/puppet/provider/jenkins_security_realm/cli.rb
Syntax OK
ruby -c lib/puppet/provider/jenkins_user/cli.rb
Syntax OK
ruby -c lib/puppet/type/jenkins_agent_port.rb
Syntax OK
ruby -c lib/puppet/type/jenkins_authorization_strategy.rb
Syntax OK
ruby -c lib/puppet/type/jenkins_credentials.rb
Syntax OK
ruby -c lib/puppet/type/jenkins_job.rb
Syntax OK
ruby -c lib/puppet/type/jenkins_num_executors.rb
Syntax OK
ruby -c lib/puppet/type/jenkins_security_realm.rb
Syntax OK
ruby -c lib/puppet/type/jenkins_user.rb
Syntax OK
ruby -c lib/puppet/x/jenkins/config.rb
ruby -c lib/puppet/x/jenkins/provider/cli.rb
Syntax OK
ruby -c lib/puppet/x/jenkins/provider.rb
Syntax OK
ruby -c lib/puppet/x/jenkins/type/cli.rb
Syntax OK
ruby -c lib/puppet/x/jenkins/type.rb
Syntax OK
ruby -c lib/puppet/x/jenkins/util.rb
Syntax OK
ruby -c lib/puppet/x/jenkins.rb
Syntax OK
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
PS C:\devel\puppet-jenkins> bundle exec rake rubocop
Running RuboCop...
Inspecting 86 files
......................................................................................

86 files inspected, no offenses detected

Thanks heaps for taking the time to review this module and any issues or concerns, please reach out and I'd be happy to update them asap! If there are any internal references that need to remain, please fix them or tell me to fix them :)

This Pull Request (PR) fixes the following issues

N/A - No fixes, "master" and "slave" terminology refactored to "controller" and "agent"

[yakatz]

It wasn't clear to me whether the tests are all failing because of these changes or some of them are failing for other reasons.