Strip null bytes in kmods fact #107
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
Sep 1, 2023
kenyon
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
I tested this branch on my one node that had a null byte in a kmods parameter fact, and it allowed puppet to run (finally). So I'll merge this.
For searchability, the error shown in the puppet run report log the PE console (without this patch) is Failed to apply catalog: Could not render to json: partial character in source, but hit end.
kenyon
added
enhancement
Enucatl
added a commit
to Enucatl/puppet-control-repo
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Puppet won't allow facts containing null bytes. This will remove any null bytes from values within the
kmodsfactThis Pull Request (PR) fixes the following issues
Fixes #98